You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/01/08 09:11:17 UTC
[PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
cloud-fan opened a new pull request, #53728:
URL: https://github.com/apache/spark/pull/53728
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
One step of the release process is to generate the contributor names and put them in the release notes. The script does a lot of work to find the full name of contributors, but I think it's more useful to show the github user id for credits, instead of the full name.
This PR simplifies this step: we now list contributor names in the form of `github user id (Full Name)` or without full name if the github user does not specify full name in the profile.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Simplify release process.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
manually, to generate 4.1.0 contributors
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
cursor 2.3.29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53728:
URL: https://github.com/apache/spark/pull/53728#issuecomment-3726745084
To be clear, I'm not saying about the dropping an information (full name). Instead, it's about enforcing ASF community and contributors to expose additional information. IIUC, there are three fundamental changes in this PR.
1. This PR proposed to ignore the author name of the commit. It enforces the contribution should use GitHub information.
2. This PR proposed to expose GitHub ID which enforces the Apache Spark community to show the company IDs like @databricks-david-lewis , @mswit-databricks , @michal-databricks , @vladimirg-db
Please don't get me wrong. We can do this, but we need to discuss this in the mailing list officially instead of a submarine patch because this proposal is also proposed by a company which seems to have a company policy like the above company-owned ID.
That's all what I asked here in the previous comment, @cloud-fan .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53728:
URL: https://github.com/apache/spark/pull/53728#issuecomment-3722921323
## JIRA Issue Information
=== Improvement SPARK-54960 ===
Summary: Simplify generating contributors of the release process
Assignee: None
Status: Open
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #53728:
URL: https://github.com/apache/spark/pull/53728#issuecomment-3726689904
@dongjoon-hyun this proposal does not drop full name, it's just to remove human toil to figure out the full name, and read it from the github user profile. Most of the cases we just pick the full name from github user profile, it's very rare that you happen to know this person and can correct his/her full name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #53728:
URL: https://github.com/apache/spark/pull/53728#discussion_r2674514873
##########
dev/create-release/releaseutils.py:
##########
@@ -132,124 +106,24 @@ def get_commits(tag):
print(line)
sys.exit(1)
# Separate commit digest from the body
- # From the digest we extract the hash, author and the title
+ # From the digest we extract the hash and the title
# From the body, we extract the PR number and the github username
[commit_digest, commit_body] = commit.split(commit_end_marker)
- if commit_digest.count(field_end_marker) != 2:
+ if commit_digest.count(field_end_marker) != 1:
sys.exit("Unexpected format in commit: %s" % commit_digest)
- [_hash, author, title] = commit_digest.split(field_end_marker)
+ [_hash, title] = commit_digest.split(field_end_marker)
# The PR number and github username is in the commit message
# itself and cannot be accessed through any GitHub API
pr_number = None
+ github_username = None
Review Comment:
Yes it's skipped, see https://github.com/apache/spark/pull/53728/files#diff-b5c7570e43a02752a0585f7f3de43edfc172d278540864775de7fd41e206139aR167
This function is to list commits, and we should still list all commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #53728:
URL: https://github.com/apache/spark/pull/53728#issuecomment-3736858176
thanks for the review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #53728:
URL: https://github.com/apache/spark/pull/53728#discussion_r2674709920
##########
dev/create-release/generate-contributors.py:
##########
@@ -16,32 +16,26 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-# This script automates the process of creating release notes.
+# This script generates a list of contributors between two release tags.
import os
import re
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #53728:
URL: https://github.com/apache/spark/pull/53728#discussion_r2674048820
##########
dev/create-release/releaseutils.py:
##########
@@ -132,124 +106,24 @@ def get_commits(tag):
print(line)
sys.exit(1)
# Separate commit digest from the body
- # From the digest we extract the hash, author and the title
+ # From the digest we extract the hash and the title
# From the body, we extract the PR number and the github username
[commit_digest, commit_body] = commit.split(commit_end_marker)
- if commit_digest.count(field_end_marker) != 2:
+ if commit_digest.count(field_end_marker) != 1:
sys.exit("Unexpected format in commit: %s" % commit_digest)
- [_hash, author, title] = commit_digest.split(field_end_marker)
+ [_hash, title] = commit_digest.split(field_end_marker)
# The PR number and github username is in the commit message
# itself and cannot be accessed through any GitHub API
pr_number = None
+ github_username = None
Review Comment:
I think we should probably skip the case when github_username is not found. 99% cases `github_username` should be available but there are other cases like removal of the account, co-authored commits who don't have github accounts, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #53728:
URL: https://github.com/apache/spark/pull/53728#issuecomment-3722921546
cc @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #53728:
URL: https://github.com/apache/spark/pull/53728#discussion_r2680676573
##########
dev/create-release/generate-contributors.py:
##########
@@ -16,32 +16,26 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-# This script automates the process of creating release notes.
+# This script generates a list of contributors between two release tags.
import os
import re
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54960][INFRA] Simplify generating contributors of the release process [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #53728: [SPARK-54960][INFRA] Simplify generating contributors of the release process
URL: https://github.com/apache/spark/pull/53728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org