You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "porcelli (via GitHub)" <gi...@apache.org> on 2024/11/19 01:28:08 UTC

[PR] adding OMG XSD files License info [incubator-kie-drools]

porcelli opened a new pull request, #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1847564088


##########
LICENSE:
##########
@@ -243,4 +243,142 @@ for drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/Ja
 
  Included by permission of the http://tpop.awl.com/ web site, which says:
  "You may use this code for any purpose, as long as you leave the
- copyright notice and book citation attached."
\ No newline at end of file
+ copyright notice and book citation attached."
+
+ ------------------------------------------------------------------------------------
+ for kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DI.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN11.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN14.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN15.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI15.xsd
+     kie-dmn/kie-dmn-feel/src/main/antlr4/org/kie/dmn/feel/parser/feel11/FEEL_1_1.g4

Review Comment:
   I guess `FEEL_1_1.g4` is added here by mistake? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1847583603


##########
LICENSE:
##########
@@ -243,4 +243,142 @@ for drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/Ja
 
  Included by permission of the http://tpop.awl.com/ web site, which says:
  "You may use this code for any purpose, as long as you leave the
- copyright notice and book citation attached."
\ No newline at end of file
+ copyright notice and book citation attached."
+
+ ------------------------------------------------------------------------------------
+ for kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DI.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN11.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN14.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN15.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI15.xsd
+     kie-dmn/kie-dmn-feel/src/main/antlr4/org/kie/dmn/feel/parser/feel11/FEEL_1_1.g4
+     kie-dmn/kie-dmn-feel/src/main/resources/dmn.xsd
+     kie-dmn/kie-dmn-trisotech/src/main/resources/org/kie/dmn/trisotech/validation/extension/TrisotechDMN13.xsd

Review Comment:
   I wonder if this xsd inherits OMG license. @baldimir @porcelli , do you know anything about this? -> I sent an email "license and copyright of TrisotechDMN13.xsd" to Simon and Maciej CC'ing you.
   ```
   <xsd:schema
   	xmlns="https://www.trisotech.com/spec/DMN/20191111/EXT/"
   	xmlns:dmn="https://www.omg.org/spec/DMN/20191111/MODEL/"
   	xmlns:xsd="http://www.w3.org/2001/XMLSchema"
   	elementFormDefault="qualified"
   	targetNamespace="https://www.trisotech.com/spec/DMN/20191111/EXT/">
   	<xsd:import
   		namespace="https://www.omg.org/spec/DMN/20191111/MODEL/"
   		schemaLocation="DMN13.xsd" />
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1848428579


##########
LICENSE:
##########
@@ -243,4 +243,142 @@ for drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/Ja
 
  Included by permission of the http://tpop.awl.com/ web site, which says:
  "You may use this code for any purpose, as long as you leave the
- copyright notice and book citation attached."
\ No newline at end of file
+ copyright notice and book citation attached."
+
+ ------------------------------------------------------------------------------------
+ for kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DI.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN11.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN14.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN15.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI15.xsd
+     kie-dmn/kie-dmn-feel/src/main/antlr4/org/kie/dmn/feel/parser/feel11/FEEL_1_1.g4
+     kie-dmn/kie-dmn-feel/src/main/resources/dmn.xsd
+     kie-dmn/kie-dmn-trisotech/src/main/resources/org/kie/dmn/trisotech/validation/extension/TrisotechDMN13.xsd

Review Comment:
   thank you for starting the conversation @tkobayas !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1848428127


##########
LICENSE:
##########
@@ -243,4 +243,142 @@ for drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/Ja
 
  Included by permission of the http://tpop.awl.com/ web site, which says:
  "You may use this code for any purpose, as long as you leave the
- copyright notice and book citation attached."
\ No newline at end of file
+ copyright notice and book citation attached."
+
+ ------------------------------------------------------------------------------------
+ for kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DI.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN11.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN14.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN15.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI15.xsd
+     kie-dmn/kie-dmn-feel/src/main/antlr4/org/kie/dmn/feel/parser/feel11/FEEL_1_1.g4

Review Comment:
   correct, I'll fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1849389811


##########
kie-dmn/kie-dmn-trisotech/src/main/resources/org/kie/dmn/trisotech/validation/extension/TrisotechDMN13.xsd:
##########
@@ -1,22 +1,3 @@
-<!--
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing,
-  software distributed under the License is distributed on an
-  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  KIND, either express or implied.  See the License for the
-  specific language governing permissions and limitations
-  under the License.
-  -->
-

Review Comment:
   @porcelli Per the email conversation, we don't need to remove this header? If it's intentional and you plan to re-add the header later (maybe we will check with ASF), this PR would be fine to merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1847583603


##########
LICENSE:
##########
@@ -243,4 +243,142 @@ for drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/Ja
 
  Included by permission of the http://tpop.awl.com/ web site, which says:
  "You may use this code for any purpose, as long as you leave the
- copyright notice and book citation attached."
\ No newline at end of file
+ copyright notice and book citation attached."
+
+ ------------------------------------------------------------------------------------
+ for kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DI.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN11.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN14.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN15.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI15.xsd
+     kie-dmn/kie-dmn-feel/src/main/antlr4/org/kie/dmn/feel/parser/feel11/FEEL_1_1.g4
+     kie-dmn/kie-dmn-feel/src/main/resources/dmn.xsd
+     kie-dmn/kie-dmn-trisotech/src/main/resources/org/kie/dmn/trisotech/validation/extension/TrisotechDMN13.xsd

Review Comment:
   I wonder if this xsd inherits OMG license. @baldimir @porcelli , do you know anything about this?
   ```
   <xsd:schema
   	xmlns="https://www.trisotech.com/spec/DMN/20191111/EXT/"
   	xmlns:dmn="https://www.omg.org/spec/DMN/20191111/MODEL/"
   	xmlns:xsd="http://www.w3.org/2001/XMLSchema"
   	elementFormDefault="qualified"
   	targetNamespace="https://www.trisotech.com/spec/DMN/20191111/EXT/">
   	<xsd:import
   		namespace="https://www.omg.org/spec/DMN/20191111/MODEL/"
   		schemaLocation="DMN13.xsd" />
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "LightGuard (via GitHub)" <gi...@apache.org>.
LightGuard commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1847579053


##########
LICENSE:
##########
@@ -243,4 +243,142 @@ for drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/Ja
 
  Included by permission of the http://tpop.awl.com/ web site, which says:
  "You may use this code for any purpose, as long as you leave the
- copyright notice and book citation attached."
\ No newline at end of file
+ copyright notice and book citation attached."
+
+ ------------------------------------------------------------------------------------
+ for kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DI.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN11.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN14.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMN15.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI12.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI13.xsd
+     kie-dmn/kie-dmn-backend/src/test/resources/DMNDI15.xsd
+     kie-dmn/kie-dmn-feel/src/main/antlr4/org/kie/dmn/feel/parser/feel11/FEEL_1_1.g4

Review Comment:
   Same question



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1848820180


##########
kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd:
##########
@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
+

Review Comment:
   no particular reason other than have all related files in the same commit :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#issuecomment-2484646317

   rat check would pass with the change.
   ```diff
   $ git diff
   diff --git a/.rat-excludes b/.rat-excludes
   index f7bad0bc28..5355198b63 100644
   --- a/.rat-excludes
   +++ b/.rat-excludes
   @@ -21,7 +21,8 @@ TestingEmptyFile\.txt
    .*\.pmml_json
    .*\.drl_json
    .*\.dslr
   -DMN.*\.xsd
   +.*DMN.*\.xsd
   +dmn.xsd
    DC\.xsd
    DI\.xsd
    KiePMML.*\.txt
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#issuecomment-2484640730

   FYI) In https://github.com/apache/incubator-kie-kogito-runtimes/pull/3714 , @pjfanning suggested to file a LEGAL JIRA to confirm if OMG license is safe to use. Filed this : https://issues.apache.org/jira/browse/LEGAL-690


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1848773785


##########
kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd:
##########
@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
+

Review Comment:
   is there a reason to add all the blank lines?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1849389811


##########
kie-dmn/kie-dmn-trisotech/src/main/resources/org/kie/dmn/trisotech/validation/extension/TrisotechDMN13.xsd:
##########
@@ -1,22 +1,3 @@
-<!--
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing,
-  software distributed under the License is distributed on an
-  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  KIND, either express or implied.  See the License for the
-  specific language governing permissions and limitations
-  under the License.
-  -->
-

Review Comment:
   @porcelli Per the email conversation, we don't need to remove this header? If you plan to re-add it with another PR, this PR would be fine to merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156#discussion_r1850023195


##########
kie-dmn/kie-dmn-trisotech/src/main/resources/org/kie/dmn/trisotech/validation/extension/TrisotechDMN13.xsd:
##########
@@ -1,22 +1,3 @@
-<!--
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing,
-  software distributed under the License is distributed on an
-  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  KIND, either express or implied.  See the License for the
-  specific language governing permissions and limitations
-  under the License.
-  -->
-

Review Comment:
   agree, will revert this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] adding OMG XSD files License info [incubator-kie-drools]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli merged PR #6156:
URL: https://github.com/apache/incubator-kie-drools/pull/6156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org