You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2022/12/12 07:50:14 UTC

[kudu-CR] KUDU-3371 [fs] make LogBlockManager as a base class

Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18709

to look at the new patch set (#5).

Change subject: KUDU-3371 [fs] make LogBlockManager as a base class
......................................................................

KUDU-3371 [fs] make LogBlockManager as a base class

This patch makes LogBlockManager as a base class, and adds
FileMetaLogBlockManager inherit from it.
FileMetaLogBlockManageris the log-backed block manager which
manage the sequential written file to store containers' metadata,
it is how we do as before.

Most of member functions are left in base class LogBlockManager
to avoid too large updating on existing code, I'm planning to do
that in next patches.

Change-Id: I59c1287a9539668e0c08036452bb96a3006ed356
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
6 files changed, 78 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/18709/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59c1287a9539668e0c08036452bb96a3006ed356
Gerrit-Change-Number: 18709
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>