You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "extinguish (via GitHub)" <gi...@apache.org> on 2024/08/11 08:40:16 UTC
[PR] greenhills support: fix the build warning for ghs platform [nuttx]
extinguish opened a new pull request, #12886:
URL: https://github.com/apache/nuttx/pull/12886
## Summary
1. fix the enum type mixed using warning
2. fix the undefined macro using warning
3. fix the unknown attribute handling warning
4. fix the declaration out of visible warning
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] greenhills support: fix the build warning for ghs platform [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12886:
URL: https://github.com/apache/nuttx/pull/12886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] greenhills support: fix the build warning for ghs platform [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12886:
URL: https://github.com/apache/nuttx/pull/12886#discussion_r1713097027
##########
include/nuttx/sched.h:
##########
@@ -72,6 +72,18 @@
# define CONFIG_SCHED_SPORADIC_MAXREPL 3
#endif
+#ifndef CONFIG_SCHED_CRITMONITOR_MAXTIME_THREAD
+# define CONFIG_SCHED_CRITMONITOR_MAXTIME_THREAD -1
Review Comment:
These symbols are only used in sched_critmonitor.c, why are there these errors? You need to align your code with the mainline:
https://github.com/apache/nuttx/blob/master/sched/sched/sched_critmonitor.c#L41-L51
##########
include/nuttx/compiler.h:
##########
@@ -254,11 +254,21 @@
/* The nooptimiziation_function attribute no optimize */
-# define nooptimiziation_function __attribute__((optimize(0)))
+# if defined(__clang__)
Review Comment:
could we separate the GHS chapters from the GNUC? They have a lot of syntax differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] greenhills support: fix the build warning for ghs platform [nuttx]
Posted by "extinguish (via GitHub)" <gi...@apache.org>.
extinguish commented on PR #12886:
URL: https://github.com/apache/nuttx/pull/12886#issuecomment-2308632048
@anchao the review comments are fixed, please help to make a review, very grateflu thanks ^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] greenhills support: fix the build warning for ghs platform [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12886:
URL: https://github.com/apache/nuttx/pull/12886#discussion_r1730375876
##########
include/nuttx/compiler.h:
##########
@@ -1110,6 +1110,18 @@
#endif
+/* Green Hills Software definitions *****************************************/
+
+#if defined(__ghs__)
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] greenhills support: fix the build warning for ghs platform [nuttx]
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #12886:
URL: https://github.com/apache/nuttx/pull/12886#discussion_r1730200792
##########
include/nuttx/compiler.h:
##########
@@ -1110,6 +1110,18 @@
#endif
+/* Green Hills Software definitions *****************************************/
+
+#if defined(__ghs__)
Review Comment:
I think this should be placed under `#ifdef __GNUC__` block above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] greenhills support: fix the build warning for ghs platform [nuttx]
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #12886:
URL: https://github.com/apache/nuttx/pull/12886#discussion_r1730201002
##########
include/nuttx/compiler.h:
##########
@@ -1110,6 +1110,18 @@
#endif
+/* Green Hills Software definitions *****************************************/
+
+#if defined(__ghs__)
Review Comment:
Sorry, I missed https://github.com/apache/nuttx/pull/12886#discussion_r1713097499 when was posting a review.
Still I think that if greenhills compiler defines `__GNUC__` the `#if defined(__ghs__)` should be encapsulated under `__GNUC__ ` branch and not at the end off all compilers selection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org