You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adam Heath <do...@brainfood.com> on 2009/10/10 00:45:35 UTC
Re: svn commit: r823633 - in /ofbiz/trunk: applications/order/src/org/ofbiz/order/shoppingcart/
applications/product/src/org/ofbiz/shipment/packing/ applications/product/src/org/ofbiz/shipment/verify/
applications/product/src/org/ofbiz/shipment/weightPacka...
adrianc@apache.org wrote:
> Modified: ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingSession.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingSession.java?rev=823633&r1=823632&r2=823633&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingSession.java (original)
> +++ ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingSession.java Fri Oct 9 17:44:24 2009
> @@ -34,7 +34,6 @@
> import org.ofbiz.base.util.GeneralException;
> import org.ofbiz.base.util.UtilFormatOut;
> import org.ofbiz.base.util.UtilMisc;
> -import org.ofbiz.base.util.UtilObject;
> import org.ofbiz.base.util.UtilValidate;
> import org.ofbiz.entity.Delegator;
> import org.ofbiz.entity.DelegatorFactory;
> @@ -502,11 +501,7 @@
>
> public Delegator getDelegator() {
> if (_delegator == null) {
> - try {
> - _delegator = UtilObject.getObjectFromFactory(DelegatorFactory.class, delegatorName);
> - } catch (ClassNotFoundException e) {
> - Debug.logError(e, module);
> - }
> + _delegator = DelegatorFactory.getDelegator(delegatorName);
> }
> return _delegator;
> }
>
This is not to Adrian, but why is the variable prefixed with '_'?
That's bad form.