You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Reynold Xin (JIRA)" <ji...@apache.org> on 2015/07/28 08:22:04 UTC

[jira] [Commented] (SPARK-9398) Add unit test for null inputs for date functions

    [ https://issues.apache.org/jira/browse/SPARK-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643919#comment-14643919 ] 

Reynold Xin commented on SPARK-9398:
------------------------------------

cc [~adrian-wang]

When you add new expressions, please make sure you also add null cases.


> Add unit test for null inputs for date functions
> ------------------------------------------------
>
>                 Key: SPARK-9398
>                 URL: https://issues.apache.org/jira/browse/SPARK-9398
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Reynold Xin
>            Assignee: Yijie Shen
>            Priority: Critical
>
> Unit tests in DateExpressionsSuite didn't cover null inputs.
> For each expression, we should add test cases where inputs were null to test behavior with null inputs.
> Note that I have a related pull request https://github.com/apache/spark/pull/7718 that added null test cases for next_day.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org