You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/25 17:36:59 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #14460: [Broker] Remove `AddEntryMetadataException` and `addBrokerEntryMetadata`

eolivelli commented on a change in pull request #14460:
URL: https://github.com/apache/pulsar/pull/14460#discussion_r814964154



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
##########
@@ -1525,11 +1525,6 @@ private static ByteBufPair serializeCommandSendWithSize(BaseCommand cmd, Checksu
         return command;
     }
 
-    public static ByteBuf addBrokerEntryMetadata(ByteBuf headerAndPayload,

Review comment:
       Unfortunately we have protocol handlers and we can't easily drop 'public' classes and methods




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org