You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Brian Foster (Created) (JIRA)" <ji...@apache.org> on 2011/11/19 21:28:51 UTC
[jira] [Created] (OODT-353) getXmlRpcProduct and
getProductFromXmlRpc should allow null values for product member variables
since Product is just a carrier object
getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
--------------------------------------------------------------------------------------------------------------------------------------
Key: OODT-353
URL: https://issues.apache.org/jira/browse/OODT-353
Project: OODT
Issue Type: Bug
Components: file manager
Affects Versions: 0.3
Environment: none
Reporter: Brian Foster
Assignee: Brian Foster
Priority: Minor
Fix For: 0.4
The following should not have to happen (take from line 1753 of XmlRpcFileManagerClient):
{code}
Product product = new Product();
product.setProductName(" ");
product.setProductStructure(" ");
product.setProductType(client.getProductTypeByName(productTypeName));
product.setProductId(productId);
{code}
The following should work:
{code}
Product product = new Product();
product.setProductType(client.getProductTypeByName(productTypeName));
product.setProductId(productId);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OODT-353) getXmlRpcProduct and
getProductFromXmlRpc should allow null values for product member variables
since Product is just a carrier object
Posted by "Brian Foster (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster resolved OODT-353.
-------------------------------
Resolution: Fixed
- fixed in r1204299
> getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-353
> URL: https://issues.apache.org/jira/browse/OODT-353
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-353.2011-11-19(2).patch.txt, OODT-353.2011-11-19(3).patch.txt, OODT-353.2011-11-19(4).patch.txt, OODT-353.2011-11-19.patch.txt
>
>
> The following should not have to happen (take from line 1753 of XmlRpcFileManagerClient):
> {code}
> Product product = new Product();
> product.setProductName(" ");
> product.setProductStructure(" ");
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
> The following should work:
> {code}
> Product product = new Product();
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-353) getXmlRpcProduct and
getProductFromXmlRpc should allow null values for product member variables
since Product is just a carrier object
Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-353:
------------------------------
Attachment: OODT-353.2011-11-19(3).patch.txt
- attached patch
> getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-353
> URL: https://issues.apache.org/jira/browse/OODT-353
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-353.2011-11-19(2).patch.txt, OODT-353.2011-11-19(3).patch.txt, OODT-353.2011-11-19.patch.txt
>
>
> The following should not have to happen (take from line 1753 of XmlRpcFileManagerClient):
> {code}
> Product product = new Product();
> product.setProductName(" ");
> product.setProductStructure(" ");
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
> The following should work:
> {code}
> Product product = new Product();
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-353) getXmlRpcProduct and
getProductFromXmlRpc should allow null values for product member variables
since Product is just a carrier object
Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-353:
------------------------------
Attachment: OODT-353.2011-11-19(2).patch.txt
Attached patch with updates:
- Product rootRef was getting lost in serialization
- Add a MockCatalog and MockCatalogFactory for use in unit-tests
- Add unit-tests which tests Product serialization and deserialization via ingestProduct and getProductById
> getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-353
> URL: https://issues.apache.org/jira/browse/OODT-353
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-353.2011-11-19(2).patch.txt, OODT-353.2011-11-19.patch.txt
>
>
> The following should not have to happen (take from line 1753 of XmlRpcFileManagerClient):
> {code}
> Product product = new Product();
> product.setProductName(" ");
> product.setProductStructure(" ");
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
> The following should work:
> {code}
> Product product = new Product();
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-353) getXmlRpcProduct and
getProductFromXmlRpc should allow null values for product member variables
since Product is just a carrier object
Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-353:
------------------------------
Attachment: OODT-353.2011-11-19(4).patch.txt
- attached patch
> getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-353
> URL: https://issues.apache.org/jira/browse/OODT-353
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-353.2011-11-19(2).patch.txt, OODT-353.2011-11-19(3).patch.txt, OODT-353.2011-11-19(4).patch.txt, OODT-353.2011-11-19.patch.txt
>
>
> The following should not have to happen (take from line 1753 of XmlRpcFileManagerClient):
> {code}
> Product product = new Product();
> product.setProductName(" ");
> product.setProductStructure(" ");
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
> The following should work:
> {code}
> Product product = new Product();
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-353) getXmlRpcProduct and
getProductFromXmlRpc should allow null values for product member variables
since Product is just a carrier object
Posted by "Brian Foster (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153582#comment-13153582 ]
Brian Foster commented on OODT-353:
-----------------------------------
- patch can be reviewed here: https://reviews.apache.org/r/2884/
> getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-353
> URL: https://issues.apache.org/jira/browse/OODT-353
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-353.2011-11-19.patch.txt
>
>
> The following should not have to happen (take from line 1753 of XmlRpcFileManagerClient):
> {code}
> Product product = new Product();
> product.setProductName(" ");
> product.setProductStructure(" ");
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
> The following should work:
> {code}
> Product product = new Product();
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-353) getXmlRpcProduct and
getProductFromXmlRpc should allow null values for product member variables
since Product is just a carrier object
Posted by "Chris A. Mattmann (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153587#comment-13153587 ]
Chris A. Mattmann commented on OODT-353:
----------------------------------------
Agreed! Patch looks great, and ship it from me per RB.
> getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-353
> URL: https://issues.apache.org/jira/browse/OODT-353
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-353.2011-11-19.patch.txt
>
>
> The following should not have to happen (take from line 1753 of XmlRpcFileManagerClient):
> {code}
> Product product = new Product();
> product.setProductName(" ");
> product.setProductStructure(" ");
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
> The following should work:
> {code}
> Product product = new Product();
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-353) getXmlRpcProduct and
getProductFromXmlRpc should allow null values for product member variables
since Product is just a carrier object
Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-353:
------------------------------
Attachment: OODT-353.2011-11-19.patch.txt
- attached patch
- will attach unit-tests
> getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-353
> URL: https://issues.apache.org/jira/browse/OODT-353
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-353.2011-11-19.patch.txt
>
>
> The following should not have to happen (take from line 1753 of XmlRpcFileManagerClient):
> {code}
> Product product = new Product();
> product.setProductName(" ");
> product.setProductStructure(" ");
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
> The following should work:
> {code}
> Product product = new Product();
> product.setProductType(client.getProductTypeByName(productTypeName));
> product.setProductId(productId);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira