[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2141: FILTERING ON|OFF in cqlsh

["smiklosovic (via GitHub)" <gi...@apache.org>]

smiklosovic commented on code in PR #2141:
URL: https://github.com/apache/cassandra/pull/2141#discussion_r1096516850


##########
pylib/cqlshlib/cqlshmain.py:
##########
@@ -967,7 +968,10 @@ def perform_simple_statement(self, statement):
         if not statement:
             return False, None
 
-        future = self.session.execute_async(statement, trace=self.tracing_enabled)
+        query_to_execute = statement.query_string
+        if self.filtering_enabled:
+            query_to_execute = statement.query_string[:-1] + " ALLOW FILTERING;"

Review Comment:
   @clohfink possibly to ALTER, hardly to DECRIBE as that is kind of done differently as we are just getting what Cassandra gives us ... well ... I think that returning to having a property (not schema property!) on TableMetadata and tweaked comment about enabling ALLOW FILTERING is just better after all.
   
   BTW I would not modify comments for each vtable being able to be filtered on. That would be a default state. We would mention that only if _ALLOW FILTERING is not possible_.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org