[GitHub] [tvm] MarisaKirisame commented on pull request #11091: [AOT] Enable A-Normal Form in the AOT executor

[GitBox <gi...@apache.org>]

MarisaKirisame commented on PR #11091:
URL: https://github.com/apache/tvm/pull/11091#issuecomment-1109978774

   Not much comment about the code, as I didnt know this part of the codebase well, but -
   as the author of the ToANF pass very happy to see it replacing the graph mode :)
   making recursive tuple possible is also great - it is a feature needed for reverse mode ad which is needed for training.
   
   What do you guys want to do with analyzing memory for example? What branchy network do you guys have in mind? I was working on saving memory for deep learning and think it is very relevant to [Dynamic Tensor Rematerialization](https://arxiv.org/abs/2006.09616) - it can work even for full inference, but most 'straight-forward' network dont really have saving, only on network with a more complex structure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org