You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/09 05:17:33 UTC

[GitHub] [pulsar-helm-chart] tisonkun commented on a diff in pull request #292: replace handmade release script with official action

tisonkun commented on code in PR #292:
URL: https://github.com/apache/pulsar-helm-chart/pull/292#discussion_r990735145


##########
.github/workflows/release.yml:
##########
@@ -17,39 +17,36 @@
 # under the License.
 #
 
-name: Post commit - Publish Pulsar Helm Chart
+name: Release Pulsar Helm Charts
 on:
+  workflow_dispatch:
   push:
     branches:
-      - master 
+      - master
+
 jobs:
   release:
     runs-on: ubuntu-latest
     timeout-minutes: 45
+    permissions:
+      contents: write
     steps:
-      - name: checkout
-        uses: actions/checkout@v2
+      - name: Checkout
+        uses: actions/checkout@v3
         with:
-          token: ${{ secrets.PULSARBOT_TOKEN }}
           fetch-depth: 0
 
-      - name: Tune Runner VM
-        uses: ./.github/actions/tune-runner-vm
+      - name: Configure Git
+        run: |
+          git config user.name "$GITHUB_ACTOR"
+          git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
-      - name: Detect changed files
-        id:   changes
-        uses: apache/pulsar-test-infra/paths-filter@master
+      - name: Install Helm
+        uses: azure/setup-helm@v1

Review Comment:
   This action is too complex to bundle. An INFRA ticket already adds this action to the whitelist: https://issues.apache.org/jira/browse/INFRA-23716



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org