You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by yu...@apache.org on 2021/01/07 04:19:49 UTC

[incubator-echarts] 01/01: fix(Gauge): pointer.offsetCenter doesn't work without icon #13962

This is an automated email from the ASF dual-hosted git repository.

yufeng04 pushed a commit to branch fix-13962
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 2d7e98c3819195fd6e87ab3f3f8a7a0e56c3fbf9
Author: yufeng04 <74...@qq.com>
AuthorDate: Thu Jan 7 12:16:16 2021 +0800

    fix(Gauge): pointer.offsetCenter doesn't work without icon #13962
---
 src/chart/gauge/GaugeView.ts | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/chart/gauge/GaugeView.ts b/src/chart/gauge/GaugeView.ts
index 82bcdfe..d40dc8e 100644
--- a/src/chart/gauge/GaugeView.ts
+++ b/src/chart/gauge/GaugeView.ts
@@ -356,6 +356,8 @@ class GaugeView extends ChartView {
             const pointerLength = parsePercent(pointerModel.get('length'), posInfo.r);
             const pointerStr = seriesModel.get(['pointer', 'icon']);
             const pointerOffset = pointerModel.get('offsetCenter');
+            const pointerOffsetX = parsePercent(pointerOffset[0], posInfo.r);
+            const pointerOffsetY = parsePercent(pointerOffset[1], posInfo.r);
             const pointerKeepAspect = pointerModel.get('keepAspect');
 
             let pointer;
@@ -363,8 +365,8 @@ class GaugeView extends ChartView {
             if (pointerStr) {
                 pointer = createSymbol(
                     pointerStr,
-                    parsePercent(pointerOffset[0], posInfo.r) - pointerWidth / 2,
-                    parsePercent(pointerOffset[1], posInfo.r) - pointerLength,
+                    pointerOffsetX - pointerWidth / 2,
+                    pointerOffsetY - pointerLength,
                     pointerWidth,
                     pointerLength,
                     null,
@@ -375,8 +377,10 @@ class GaugeView extends ChartView {
                 pointer = new PointerPath({
                     shape: {
                         angle: -Math.PI / 2,
-                        width: parsePercent(pointerModel.get('width'), posInfo.r),
-                        r: parsePercent(pointerModel.get('length'), posInfo.r)
+                        width: pointerWidth,
+                        r: pointerLength,
+                        x: pointerOffsetX,
+                        y: pointerOffsetY
                     }
                 });
             }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org