You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/28 15:24:15 UTC

[GitHub] [flink] leozhangsr opened a new pull request, #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

leozhangsr opened a new pull request, #20387:
URL: https://github.com/apache/flink/pull/20387

   ## What is the purpose of the change
   Stopping offset can be 0.When we make a zero stopping offset empty,it would be serialized to NO_STOPPING_OFFSET, which it is not expected.
   It' had been fixed in master by https://github.com/apache/flink/pull/20234, now need to merge into release-1.14.
   
   ## Brief change log
   change a stopping offset conditon from '>0' to '>=0'
   
   ## Verifying this change
   Can be verified by:
   KafkaPartitionSplitReaderTest#testAssignEmptySplit
   KafkaPartitionSplitSerializerTest
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20387:
URL: https://github.com/apache/flink/pull/20387#issuecomment-1198311588

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f0aa4e736f19bf742663ed9a09aaf9d1e58f3d21",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f0aa4e736f19bf742663ed9a09aaf9d1e58f3d21",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f0aa4e736f19bf742663ed9a09aaf9d1e58f3d21 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

Posted by GitBox <gi...@apache.org>.
leozhangsr commented on PR #20387:
URL: https://github.com/apache/flink/pull/20387#issuecomment-1200156751

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

Posted by GitBox <gi...@apache.org>.
leozhangsr commented on PR #20387:
URL: https://github.com/apache/flink/pull/20387#issuecomment-1200599164

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

Posted by GitBox <gi...@apache.org>.
leozhangsr commented on PR #20387:
URL: https://github.com/apache/flink/pull/20387#issuecomment-1198900364

   It has a Compilation failure here,I will modified it later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] PatrickRen commented on pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

Posted by GitBox <gi...@apache.org>.
PatrickRen commented on PR #20387:
URL: https://github.com/apache/flink/pull/20387#issuecomment-1198963190

   The CI failed with compilation error. @leozhangsr Could you please take a look? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr closed pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

Posted by "leozhangsr (via GitHub)" <gi...@apache.org>.
leozhangsr closed pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.
URL: https://github.com/apache/flink/pull/20387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

Posted by GitBox <gi...@apache.org>.
leozhangsr commented on PR #20387:
URL: https://github.com/apache/flink/pull/20387#issuecomment-1223747350

   This mr still not merge yet, can anyone help?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

Posted by "leozhangsr (via GitHub)" <gi...@apache.org>.
leozhangsr commented on PR #20387:
URL: https://github.com/apache/flink/pull/20387#issuecomment-1680079293

   Already close since flink0.15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org