You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2024/12/29 13:20:02 UTC

[PR] KAFKA-18361: Remove PasswordEncoderConfigs [kafka]

frankvicky opened a new pull request, #18347:
URL: https://github.com/apache/kafka/pull/18347

   JIRA: KAFKA-18361
   
   > In `kfrat` mode, we do not encrypt the values in records.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18361: Remove PasswordEncoderConfigs [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #18347:
URL: https://github.com/apache/kafka/pull/18347


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18361: Remove PasswordEncoderConfigs [kafka]

Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #18347:
URL: https://github.com/apache/kafka/pull/18347#discussion_r1899538540


##########
docs/upgrade.html:
##########
@@ -56,6 +56,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
                         <li>The <code>org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerValidatorCallbackHandler</code> class was removed.
                             Please use the <code>org.apache.kafka.common.security.oauthbearer.OAuthBearerValidatorCallbackHandler</code> class instead.
                         </li>
+                        <li>The <code>org.apache.kafka.common.security.PasswordEncoderConfigs</code> class was removed.

Review Comment:
   I have modified the doc as following: 
   ![Screenshot from 2024-12-30 21-15-08](https://github.com/user-attachments/assets/cfb30710-c073-4732-819c-be293724f09b)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18361: Remove PasswordEncoderConfigs [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #18347:
URL: https://github.com/apache/kafka/pull/18347#discussion_r1899523219


##########
docs/upgrade.html:
##########
@@ -56,6 +56,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
                         <li>The <code>org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerValidatorCallbackHandler</code> class was removed.
                             Please use the <code>org.apache.kafka.common.security.oauthbearer.OAuthBearerValidatorCallbackHandler</code> class instead.
                         </li>
+                        <li>The <code>org.apache.kafka.common.security.PasswordEncoderConfigs</code> class was removed.

Review Comment:
   Could you please list the removed configs instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18361: Remove PasswordEncoderConfigs [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18347:
URL: https://github.com/apache/kafka/pull/18347#issuecomment-2565677381

   the failed tests are traced by following jiras:
   
   https://issues.apache.org/jira/browse/KAFKA-18298
   https://issues.apache.org/jira/browse/KAFKA-15474
   https://issues.apache.org/jira/browse/KAFKA-17676


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org