You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by ch...@huawei.com on 2011/08/09 21:11:13 UTC
Review Request: Ensure HiveConf includes all properties defined in
hive-default.xml
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
Review request for hive, Carl Steinbach and John Sichi.
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275
trunk/conf/hive-default.xml 1155275
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1155275
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1155275
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1155275
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1155275
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1155275
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1155275
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
Re: Review Request: Ensure HiveConf includes all properties defined in
hive-default.xml
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/#review1451
-----------------------------------------------------------
>> The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
Actually, everything that appears in hive-default.xml should also appear in HiveConf and vice-versa.
- Carl
On 2011-08-09 19:11:13, chinna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1423/
> -----------------------------------------------------------
>
> (Updated 2011-08-09 19:11:13)
>
>
> Review request for hive, Carl Steinbach and John Sichi.
>
>
> Summary
> -------
>
> The below configurations are not used in the code base so removed from the hive-default.xml
>
> hive.mapjoin.hashtable.initialCapacity
> hive.mapjoin.hashtable.loadfactor
> hive.mapjoin.smalltable.filesize
> hive.optimize.pruner
> hive.stats.jdbc.atomic
> hive.concurrency.manager
>
> The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
>
> javax.jdo.option.ConnectionDriverName
> javax.jdo.PersistenceManagerFactoryClass
> javax.jdo.option.DetachAllOnCommit
> javax.jdo.option.NonTransactionalRead
> javax.jdo.option.ConnectionUserName
> fs.har.impl
>
>
> This addresses bug HIVE-2196.
> https://issues.apache.org/jira/browse/HIVE-2196
>
>
> Diffs
> -----
>
> trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275
> trunk/conf/hive-default.xml 1155275
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1155275
> trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1155275
> trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1155275
> trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1155275
> trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1155275
> trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1155275
> trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275
>
> Diff: https://reviews.apache.org/r/1423/diff
>
>
> Testing
> -------
>
> All unit tests passed
>
>
> Thanks,
>
> chinna
>
>
Re: Review Request: Ensure HiveConf includes all properties defined in
hive-default.xml
Posted by ch...@huawei.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-11-08 07:07:28.602261)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
refreshed the patch
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1198626
trunk/conf/hive-default.xml 1198626
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1198626
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
Re: Review Request: Ensure HiveConf includes all properties defined in
hive-default.xml
Posted by ch...@huawei.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-10-14 16:54:00.383612)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
Rebase the patch on the trunk
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182263
trunk/conf/hive-default.xml 1182263
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1182263
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1182263
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1182263
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1182263
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1182263
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1182263
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1182263
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
Re: Review Request: Ensure HiveConf includes all properties defined in
hive-default.xml
Posted by ch...@huawei.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-09-27 15:51:37.029125)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
All tests passed
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1175859
trunk/conf/hive-default.xml 1175859
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1175859
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1175859
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1175859
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1175859
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1175859
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1175859
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1175859
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
Re: Review Request: Ensure HiveConf includes all properties defined in
hive-default.xml
Posted by ch...@huawei.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-09-06 06:16:26.733090)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
Reworked on the patch and latest patch taken care the below issues
1) Configuration property values verified and made it sync with the hive-default.xml
2) Compilation failure corrected.
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1165244
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1165244
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1165244
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1165244
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1165244
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1165244
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1165244
trunk/conf/hive-default.xml 1165244
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1165244
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna
Re: Review Request: Ensure HiveConf includes all properties defined in
hive-default.xml
Posted by ch...@huawei.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/
-----------------------------------------------------------
(Updated 2011-08-16 14:51:32.766435)
Review request for hive, Carl Steinbach and John Sichi.
Changes
-------
These configurations are added to HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
Summary
-------
The below configurations are not used in the code base so removed from the hive-default.xml
hive.mapjoin.hashtable.initialCapacity
hive.mapjoin.hashtable.loadfactor
hive.mapjoin.smalltable.filesize
hive.optimize.pruner
hive.stats.jdbc.atomic
hive.concurrency.manager
The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
javax.jdo.option.ConnectionDriverName
javax.jdo.PersistenceManagerFactoryClass
javax.jdo.option.DetachAllOnCommit
javax.jdo.option.NonTransactionalRead
javax.jdo.option.ConnectionUserName
fs.har.impl
This addresses bug HIVE-2196.
https://issues.apache.org/jira/browse/HIVE-2196
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1158213
trunk/conf/hive-default.xml 1158213
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1158213
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1158213
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1158213
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1158213
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1158213
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1158213
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1158213
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1158213
Diff: https://reviews.apache.org/r/1423/diff
Testing
-------
All unit tests passed
Thanks,
chinna