[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2915: apps: Allow stub/full implementation of packages in syscfg

["sjanc (via GitHub)" <gi...@apache.org>]

sjanc commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1093231836


##########
sys/console/syscfg.yml:
##########
@@ -17,10 +17,17 @@
 #
 
 syscfg.defs:
-    CONSOLE_MODE:
-        description: Which console to use
+    CONSOLE_IMPLEMENTATION:
+        description: >
+            Selects console implementation package full, minimal or stub.
         value:
         choices:
             - full
             - minimal
             - stub
+
+    # Defunct settings
+
+    CONSOLE_MODE:
+        description: Use 'CONSOLE_IMPLEMENTATION' instead
+        defunct: 1

Review Comment:
   I think this should initially be "deprecated" instead of defunc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org