You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Ashish Nagar (JIRA)" <ji...@apache.org> on 2009/02/27 13:41:12 UTC
[jira] Created: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
If subject of verification mail does not exists then also functionality should not be broken.
---------------------------------------------------------------------------------------------
Key: OFBIZ-2212
URL: https://issues.apache.org/jira/browse/OFBIZ-2212
Project: OFBiz
Issue Type: Bug
Components: ecommerce
Affects Versions: SVN trunk
Reporter: Ashish Nagar
Priority: Blocker
Fix For: SVN trunk
If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677664#action_12677664 ]
Ashish Vijaywargiya commented on OFBIZ-2212:
--------------------------------------------
Hello Ashish Nagar,
Thanks for your contribution.
I think we should improve this patch.
Try to find the places where "title" attribute is defined and fetching values from uiLableMap and the uiLabelMap is not available in the scope.
For example :
In the below screen definition we have defined the "title" attribute and we are fetching the values from uiLabelMap which is not available in the scope.
<screen name="BackorderNotice">
<section>
<actions>
<set field="title" value="${uiLabelMap.PageTitleOrderBackorderNotice}"/>
So we should change the above code into :
<screen name="BackorderNotice">
<section>
<actions>
<property-map resource="EcommerceUiLabels" map-name="uiLabelMap" global="true"/>
<set field="title" value="${uiLabelMap.PageTitleOrderBackorderNotice}"/>
If above comment is not clear then please let me know.
Although the empty check on "title" in the updated patch is good to keep.
Thanks !
--
Ashish
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Assignee: Ashish Vijaywargiya
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Nagar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677916#action_12677916 ]
Ashish Nagar commented on OFBIZ-2212:
-------------------------------------
Thanks Ashish,
I would love to improve this patch as you guided & will update it soon.
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Assignee: Ashish Vijaywargiya
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-2212.
--------------------------------------
Resolution: Fixed
Thanks Ashish Nagar for your contribution.
Your patch is now in trunk at rev no. 754837.
Your patch was for ecommerce component inside "application" folder but we don't have ecommerce component there now ;).
--
Ashish
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Assignee: Ashish Vijaywargiya
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch, OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Nagar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Nagar updated OFBIZ-2212:
--------------------------------
Attachment: OFBIZ-2212.patch
This patch will remove the dependency to have 'title'.
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Nagar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Nagar updated OFBIZ-2212:
--------------------------------
Attachment: (was: OFBIZ-2212.patch)
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Assignee: Ashish Vijaywargiya
> Priority: Blocker
> Fix For: SVN trunk
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Nagar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Nagar updated OFBIZ-2212:
--------------------------------
Attachment: OFBIZ-2212.patch
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Assignee: Ashish Vijaywargiya
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-2212:
------------------------------------------
Assignee: Ashish Vijaywargiya
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Assignee: Ashish Vijaywargiya
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Nagar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Nagar updated OFBIZ-2212:
--------------------------------
Attachment: (was: OFBIZ-2212.patch)
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Nagar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Nagar updated OFBIZ-2212:
--------------------------------
Attachment: OFBIZ-2212.patch
This patch will remove the need of 'title' for the mail to be sent.
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2212) If subject of verification mail does
not exists then also functionality should not be broken.
Posted by "Ashish Nagar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Nagar updated OFBIZ-2212:
--------------------------------
Attachment: OFBIZ-2212.patch
Updated patch, so that the needed values from uiLabelMap can be accessible in ftls too.
> If subject of verification mail does not exists then also functionality should not be broken.
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2212
> URL: https://issues.apache.org/jira/browse/OFBIZ-2212
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Ashish Nagar
> Assignee: Ashish Vijaywargiya
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2212.patch, OFBIZ-2212.patch
>
>
> If Subject of verification mail is defined in data, then while displaying the value of 'title' error occurs, & blank mail is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.