You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "aleksraiden (via GitHub)" <gi...@apache.org> on 2023/04/23 08:17:38 UTC
[GitHub] [incubator-kvrocks] aleksraiden opened a new pull request, #1400: Update snappy.cmake
aleksraiden opened a new pull request, #1400:
URL: https://github.com/apache/incubator-kvrocks/pull/1400
#1309 Update Snappy to 1.10.0 with compile bug fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1400: Update snappy.cmake
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1400:
URL: https://github.com/apache/incubator-kvrocks/pull/1400#discussion_r1174534140
##########
cmake/snappy.cmake:
##########
@@ -20,8 +20,8 @@ include_guard()
include(cmake/utils.cmake)
FetchContent_DeclareGitHubWithMirror(snappy
- google/snappy 1.1.7
- MD5=40a371a653b7bb5a47df59b937b78557
+ google/snappy f725f6766bfc62418c6491b504c8e5865ec99412
Review Comment:
Didn't upstream release a tag for 1.10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #1400: build(deps): Bump Snappy 1.1.10 with upstream compile fix
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #1400:
URL: https://github.com/apache/incubator-kvrocks/pull/1400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on a diff in pull request #1400: Update snappy.cmake
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on code in PR #1400:
URL: https://github.com/apache/incubator-kvrocks/pull/1400#discussion_r1174536843
##########
cmake/snappy.cmake:
##########
@@ -20,8 +20,8 @@ include_guard()
include(cmake/utils.cmake)
FetchContent_DeclareGitHubWithMirror(snappy
- google/snappy 1.1.7
- MD5=40a371a653b7bb5a47df59b937b78557
+ google/snappy f725f6766bfc62418c6491b504c8e5865ec99412
Review Comment:
No. Release tag age broken, so we need to use directly commit state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1400: build(deps): Bump Snappy 1.1.10 with upstream compile fix
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1400:
URL: https://github.com/apache/incubator-kvrocks/pull/1400#discussion_r1174543286
##########
cmake/snappy.cmake:
##########
@@ -20,8 +20,8 @@ include_guard()
include(cmake/utils.cmake)
FetchContent_DeclareGitHubWithMirror(snappy
- google/snappy 1.1.7
- MD5=40a371a653b7bb5a47df59b937b78557
+ google/snappy f725f6766bfc62418c6491b504c8e5865ec99412
Review Comment:
Thanks for your explanation - I checked https://github.com/google/snappy/compare/1.1.10...main and understand what's tagged now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org