You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/01 18:36:43 UTC
[GitHub] [trafficserver] duke8253 opened a new pull request #8028: Use thread_local to speed things up in JeAllocator
duke8253 opened a new pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028
As mentioned in #7501 , testing whether `thread_local` helps with performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] duke8253 merged pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
duke8253 merged pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] duke8253 commented on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
duke8253 commented on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-909354676
#7501 sill has some performance improvements over the original versions actually, mainly creating a seperate arena for each thread, and it cleaned up some unnecessary code as well, so it might be a cleaner cherry pick with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-908555234
I ran benchmarks on this PR on our AMD Epyc 64/128 servers and the rps went from 35K rps to 98K rps with this change. This PR removes the reader/writer locks to fetch the arenas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-909262950
I believe (please correct me if I'm wrong) that this fixes the locking issues introduced via #7501 , which is not in 9.1.x. Do we really want to pull in #7501 for 9.1.x ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-909696733
Cherry-picked to v9.1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall edited a comment on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
bryancall edited a comment on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-908555234
I ran benchmarks on this PR on our AMD Epyc 64/128 servers and the rps went from 35K rps to 98K rps with this change. This PR removes the mutex to fetch the arenas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] duke8253 commented on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
duke8253 commented on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-909354676
#7501 sill has some performance improvements over the original versions actually, mainly creating a seperate arena for each thread, and it cleaned up some unnecessary code as well, so it might be a cleaner cherry pick with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] duke8253 merged pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
duke8253 merged pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-909262950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-909262950
I believe (please correct me if I'm wrong) that this fixes the locking issues introduced via #7501 , which is not in 9.1.x. Do we really want to pull in #7501 for 9.1.x ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall edited a comment on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
bryancall edited a comment on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-908555234
I ran benchmarks on this PR on our AMD Epyc 64/128 servers and the rps went from 35K rps to 98K rps with this change. This PR removes the mutex to fetch the arenas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8028: Use thread_local to speed things up in JeAllocator
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8028:
URL: https://github.com/apache/trafficserver/pull/8028#issuecomment-908555234
I ran benchmarks on this PR on our AMD Epyc 64/128 servers and the rps went from 35K rps to 98K rps with this change. This PR removes the reader/writer locks to fetch the arenas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org