You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Carl-Eric Menzel (JIRA)" <ji...@apache.org> on 2012/07/27 16:50:34 UTC

[jira] [Created] (WICKET-4681) AutoLinkResolver looks in the wrong scope

Carl-Eric Menzel created WICKET-4681:
----------------------------------------

             Summary: AutoLinkResolver looks in the wrong scope
                 Key: WICKET-4681
                 URL: https://issues.apache.org/jira/browse/WICKET-4681
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.5.7
            Reporter: Carl-Eric Menzel
            Assignee: Carl-Eric Menzel


When turning on MarkupSettings#automaticLinking, AutoLinkResolver is supposed to touch tags like <img> and <a> and set their src/href attributes so that packaged resources are correctly referenced.

I found a situation where that does not work: If you have a panel, and e.g. an <img> tag inside that panel, and the <img> tag is NOT enclosed in a container component, it looks for the resource in the scope of the surrounding component, not in the panel's scope. It obviously can't find it there, so it just dumps the raw attribute.

If you put that <img> tag into a MarkupContainer (like WMC) then it works correctly. So it looks like the scope is off-by-one or something like that. I'll investigate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-4681) AutoLinkResolver looks in the wrong scope

Posted by "Carl-Eric Menzel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423919#comment-13423919 ] 

Carl-Eric Menzel commented on WICKET-4681:
------------------------------------------

With <wicket:link> it works, since that introduces a container component.
                
> AutoLinkResolver looks in the wrong scope
> -----------------------------------------
>
>                 Key: WICKET-4681
>                 URL: https://issues.apache.org/jira/browse/WICKET-4681
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.7
>            Reporter: Carl-Eric Menzel
>            Assignee: Carl-Eric Menzel
>
> When turning on MarkupSettings#automaticLinking, AutoLinkResolver is supposed to touch tags like <img> and <a> and set their src/href attributes so that packaged resources are correctly referenced.
> I found a situation where that does not work: If you have a panel, and e.g. an <img> tag inside that panel, and the <img> tag is NOT enclosed in a container component, it looks for the resource in the scope of the surrounding component, not in the panel's scope. It obviously can't find it there, so it just dumps the raw attribute.
> If you put that <img> tag into a MarkupContainer (like WMC) then it works correctly. So it looks like the scope is off-by-one or something like that. I'll investigate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-4681) AutoLinkResolver looks in the wrong scope

Posted by "Carl-Eric Menzel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl-Eric Menzel resolved WICKET-4681.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.8

6.x is not affected.

I fixed it in 1.5.x by having AutoLinkResolver trying getAssociatedMarkup first before using getMarkup. That way it uses the correct scope to resolve package resources.
                
> AutoLinkResolver looks in the wrong scope
> -----------------------------------------
>
>                 Key: WICKET-4681
>                 URL: https://issues.apache.org/jira/browse/WICKET-4681
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.7
>            Reporter: Carl-Eric Menzel
>            Assignee: Carl-Eric Menzel
>             Fix For: 1.5.8
>
>
> When turning on MarkupSettings#automaticLinking, AutoLinkResolver is supposed to touch tags like <img> and <a> and set their src/href attributes so that packaged resources are correctly referenced.
> I found a situation where that does not work: If you have a panel, and e.g. an <img> tag inside that panel, and the <img> tag is NOT enclosed in a container component, it looks for the resource in the scope of the surrounding component, not in the panel's scope. It obviously can't find it there, so it just dumps the raw attribute.
> If you put that <img> tag into a MarkupContainer (like WMC) then it works correctly. So it looks like the scope is off-by-one or something like that. I'll investigate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira