You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2015/02/24 12:46:42 UTC
Re: Review Request 31187: LENS-315 Load database specific jars from
configurable location,
LENS-316 Pass database specific jars to Hive driver lazily
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31187/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 11:46 a.m.)
Review request for lens, Amareshwari Sriramadasu and Srikanth Sundarrajan.
Summary (updated)
-----------------
LENS-315 Load database specific jars from configurable location, LENS-316 Pass database specific jars to Hive driver lazily
Bugs: LENS-315 and LENS-316
https://issues.apache.org/jira/browse/LENS-315
https://issues.apache.org/jira/browse/LENS-316
Repository: lens
Description
-------
Changes -
1. Added DatabaseResourceService which loads Db specific jars and maintains DB class loaders
2. HiveSessionService starts DatabaseResourceService
3. Changed LensSessionImpl to set classloader upon DB switch, and to construct class loader using added resources + resources of current DB
Diffs
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6d95ac287c49a5ca414db46401c9045b2f3d80d7
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7b365db214fbc85e0d47137e205a17a40f7f5578
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 68559b723cf080ec6b7f41617f2d243a876a80e1
lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 320557bd092513af3f052466f115585df152f58d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 92717fee508bda112cd813f18ae6695acb484b66
lens-server/testdata/ClassLoaderTestClass.java PRE-CREATION
lens-server/testdata/ClassLoaderTestClass2.java PRE-CREATION
lens-server/testdata/test.jar PRE-CREATION
lens-server/testdata/test2.jar PRE-CREATION
src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
Diff: https://reviews.apache.org/r/31187/diff/
Testing
-------
1. Added unit tests for DatabaseResourceService
2. New unit tests related to class loading
Test output
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [6.282s]
[INFO] Lens .............................................. SUCCESS [10.048s]
[INFO] Lens API .......................................... SUCCESS [13.921s]
[INFO] Lens API for server and extensions ................ SUCCESS [14.237s]
[INFO] Lens Cube ......................................... SUCCESS [9:03.374s]
[INFO] Lens DB storage ................................... SUCCESS [16.598s]
[INFO] Lens Query Library ................................ SUCCESS [7.817s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:45.739s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.728s]
[INFO] Lens Server ....................................... SUCCESS [18:14.639s]
[INFO] Lens client ....................................... SUCCESS [51.484s]
[INFO] Lens CLI .......................................... SUCCESS [4:07.728s]
[INFO] Lens Examples ..................................... SUCCESS [7.675s]
[INFO] Lens Distribution ................................. SUCCESS [19.084s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:02.433s]
[INFO] Lens Regression ................................... SUCCESS [0.703s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:17.112s
[INFO] Finished at: Thu Feb 19 19:06:08 IST 2015
[INFO] Final Memory: 136M/834M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 31187: LENS-315 Load database specific jars from
configurable location,
LENS-316 Pass database specific jars to Hive driver lazily
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31187/#review73987
-----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
<https://reviews.apache.org/r/31187/#comment120407>
Should we add one more api to invalidate for refreshing jars or switching database and database resources are different?
Invalidate can close hive session fully, because old jars would have been already and refreshing wont make sense with new jars. So, closing old session and creating new session with new jars should be good.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/31187/#comment120409>
We might have to call this for explain as well?
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java
<https://reviews.apache.org/r/31187/#comment120411>
I dont think this flag at session is useful because resources are added only to one driver which was selected. If resources needed to be added to multiple drivers lazily, having a flag in session does not make sense
- Amareshwari Sriramadasu
On Feb. 24, 2015, 1:21 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31187/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 1:21 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Srikanth Sundarrajan.
>
>
> Bugs: LENS-315 and LENS-316
> https://issues.apache.org/jira/browse/LENS-315
> https://issues.apache.org/jira/browse/LENS-316
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes -
> 1. Added DatabaseResourceService which loads Db specific jars and maintains DB class loaders
> 2. HiveSessionService starts DatabaseResourceService
> 3. Changed LensSessionImpl to set classloader upon DB switch, and to construct class loader using added resources + resources of current DB
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6d95ac287c49a5ca414db46401c9045b2f3d80d7
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7b365db214fbc85e0d47137e205a17a40f7f5578
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 68559b723cf080ec6b7f41617f2d243a876a80e1
> lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 320557bd092513af3f052466f115585df152f58d
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
> lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 92717fee508bda112cd813f18ae6695acb484b66
> lens-server/testdata/ClassLoaderTestClass.java PRE-CREATION
> lens-server/testdata/ClassLoaderTestClass2.java PRE-CREATION
> lens-server/testdata/test.jar PRE-CREATION
> lens-server/testdata/test2.jar PRE-CREATION
> src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
>
> Diff: https://reviews.apache.org/r/31187/diff/
>
>
> Testing
> -------
>
> 1. Added unit tests for DatabaseResourceService
> 2. New unit tests related to class loading
> 3. Added new unit test in TestQueryService to verify that DB jars get passed to Hive driver before query is run
>
> Lens-server all tests are passing.
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 31187: LENS-315 Load database specific jars from
configurable location,
LENS-316 Pass database specific jars to Hive driver lazily
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31187/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 8:38 a.m.)
Review request for lens, Amareshwari Sriramadasu and Srikanth Sundarrajan.
Changes
-------
Added handling of explain and explainAndPrepare as well as prepare.
Removed flag in LensSessionImpl
Bugs: LENS-315 and LENS-316
https://issues.apache.org/jira/browse/LENS-315
https://issues.apache.org/jira/browse/LENS-316
Repository: lens
Description
-------
Changes -
1. Added DatabaseResourceService which loads Db specific jars and maintains DB class loaders
2. HiveSessionService starts DatabaseResourceService
3. Changed LensSessionImpl to set classloader upon DB switch, and to construct class loader using added resources + resources of current DB
Diffs (updated)
-----
README.md 08f995b1de41e46cf2da772c46553dfa21243a59
checkstyle/pom.xml 87bbcb39893f51046e197d833505a7e4b095e5f6
lens-api/pom.xml 50f996934f574f189804a23ec1606329eaae7243
lens-cli/pom.xml 3a5ebef92c53b7cda1cfc08ff8288ce8dd16e102
lens-client/pom.xml 54329b536ce4dab7be0635635ea5548724609b08
lens-cube/pom.xml bf4bf562c4ae37789b19932562e8438f5658d49c
lens-dist/pom.xml 0397381f753e1d71fe514df91d703afae8f7cb67
lens-docker/lens-test/Dockerfile bf6fab71101368a6b9c440c18f3d4c3f493ce324
lens-driver-hive/pom.xml d3c0e7a912ad154609f87df871a84e8b2f313fc5
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6d95ac287c49a5ca414db46401c9045b2f3d80d7
lens-driver-jdbc/pom.xml d57cb05946a5d81e82246feb16216fde7a73fd82
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 15ca19aa4c3f9953b4a84fbe3e36a8a9f7a8fe5a
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 1c04b659773448203548a6203bada8170c6c3bba
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml c715a0efa7dac413087f8e350324068b85f71e4b
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java a5843ba69a23b892a56f09f8d263fe1b4a997b84
lens-examples/pom.xml f28003bc2d0fb99a641b18dd24ec0b5daa84234c
lens-ml-lib/pom.xml 75b153c193e46ed2eea73fc9cbc3433d6cdfd471
lens-query-lib/pom.xml 22f7e46628fe0a38271599dbc9715721f469b75d
lens-regression/pom.xml a573ae04508a85373b5d6a3d7b87d682410c9e95
lens-server-api/pom.xml 0de203c709028e73314007038de773bb8d8f0cc9
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
lens-server/pom.xml 2bc7be41396147a443997ab4c621d0823a850c3f
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7b365db214fbc85e0d47137e205a17a40f7f5578
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 68559b723cf080ec6b7f41617f2d243a876a80e1
lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 320557bd092513af3f052466f115585df152f58d
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 92717fee508bda112cd813f18ae6695acb484b66
lens-server/testdata/ClassLoaderTestClass.java PRE-CREATION
lens-server/testdata/ClassLoaderTestClass2.java PRE-CREATION
lens-server/testdata/test.jar PRE-CREATION
lens-server/testdata/test2.jar PRE-CREATION
lens-storage-db/pom.xml 480421645e44c668e808228d4516cf4137d3f339
pom.xml 594ca4c5451a10410abc8fbd5d9a0f8dfa6c6a48
src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
src/site/apt/admin/deployment.apt afa524d91d790ce0774daa183293b47e0a3dae09
src/site/apt/admin/jdbcdriver-config.apt 126567a9ee15688bda9051eb1919f762d09aa747
src/site/apt/developer/contribute.apt c8885d68daf5445fd7232796e533e0964ac97020
src/site/apt/releases/compatibility.apt 453c57eb0d552aabb072e5156f55cb4ad36c7c51
src/site/apt/releases/download.apt 71a04420cef5dfc6c712ca944479190343903d51
src/site/apt/releases/release-history.apt cf255300c1c1a1bc9176b989cfeb757da9e4a259
Diff: https://reviews.apache.org/r/31187/diff/
Testing
-------
1. Added unit tests for DatabaseResourceService
2. New unit tests related to class loading
3. Added new unit test in TestQueryService to verify that DB jars get passed to Hive driver before query is run
Lens-server all tests are passing.
Thanks,
Jaideep dhok
Re: Review Request 31187: LENS-315 Load database specific jars from
configurable location,
LENS-316 Pass database specific jars to Hive driver lazily
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31187/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 1:21 p.m.)
Review request for lens, Amareshwari Sriramadasu and Srikanth Sundarrajan.
Bugs: LENS-315 and LENS-316
https://issues.apache.org/jira/browse/LENS-315
https://issues.apache.org/jira/browse/LENS-316
Repository: lens
Description
-------
Changes -
1. Added DatabaseResourceService which loads Db specific jars and maintains DB class loaders
2. HiveSessionService starts DatabaseResourceService
3. Changed LensSessionImpl to set classloader upon DB switch, and to construct class loader using added resources + resources of current DB
Diffs
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6d95ac287c49a5ca414db46401c9045b2f3d80d7
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7b365db214fbc85e0d47137e205a17a40f7f5578
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 68559b723cf080ec6b7f41617f2d243a876a80e1
lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 320557bd092513af3f052466f115585df152f58d
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 92717fee508bda112cd813f18ae6695acb484b66
lens-server/testdata/ClassLoaderTestClass.java PRE-CREATION
lens-server/testdata/ClassLoaderTestClass2.java PRE-CREATION
lens-server/testdata/test.jar PRE-CREATION
lens-server/testdata/test2.jar PRE-CREATION
src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
Diff: https://reviews.apache.org/r/31187/diff/
Testing (updated)
-------
1. Added unit tests for DatabaseResourceService
2. New unit tests related to class loading
3. Added new unit test in TestQueryService to verify that DB jars get passed to Hive driver before query is run
Lens-server all tests are passing.
Thanks,
Jaideep dhok
Re: Review Request 31187: LENS-315 Load database specific jars from
configurable location,
LENS-316 Pass database specific jars to Hive driver lazily
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31187/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 1:21 p.m.)
Review request for lens, Amareshwari Sriramadasu and Srikanth Sundarrajan.
Changes
-------
Fixed test failures in TestMetastoreService
Bugs: LENS-315 and LENS-316
https://issues.apache.org/jira/browse/LENS-315
https://issues.apache.org/jira/browse/LENS-316
Repository: lens
Description
-------
Changes -
1. Added DatabaseResourceService which loads Db specific jars and maintains DB class loaders
2. HiveSessionService starts DatabaseResourceService
3. Changed LensSessionImpl to set classloader upon DB switch, and to construct class loader using added resources + resources of current DB
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6d95ac287c49a5ca414db46401c9045b2f3d80d7
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7b365db214fbc85e0d47137e205a17a40f7f5578
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 68559b723cf080ec6b7f41617f2d243a876a80e1
lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 320557bd092513af3f052466f115585df152f58d
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 92717fee508bda112cd813f18ae6695acb484b66
lens-server/testdata/ClassLoaderTestClass.java PRE-CREATION
lens-server/testdata/ClassLoaderTestClass2.java PRE-CREATION
lens-server/testdata/test.jar PRE-CREATION
lens-server/testdata/test2.jar PRE-CREATION
src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
Diff: https://reviews.apache.org/r/31187/diff/
Testing
-------
1. Added unit tests for DatabaseResourceService
2. New unit tests related to class loading
3. Added new unit test in TestQueryService to verify that DB jars get passed to Hive driver before query is run
Will update latest test output.
Thanks,
Jaideep dhok
Re: Review Request 31187: LENS-315 Load database specific jars from
configurable location,
LENS-316 Pass database specific jars to Hive driver lazily
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31187/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 11:57 a.m.)
Review request for lens, Amareshwari Sriramadasu and Srikanth Sundarrajan.
Changes
-------
Changed testing done
Bugs: LENS-315 and LENS-316
https://issues.apache.org/jira/browse/LENS-315
https://issues.apache.org/jira/browse/LENS-316
Repository: lens
Description
-------
Changes -
1. Added DatabaseResourceService which loads Db specific jars and maintains DB class loaders
2. HiveSessionService starts DatabaseResourceService
3. Changed LensSessionImpl to set classloader upon DB switch, and to construct class loader using added resources + resources of current DB
Diffs
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6d95ac287c49a5ca414db46401c9045b2f3d80d7
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7b365db214fbc85e0d47137e205a17a40f7f5578
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 68559b723cf080ec6b7f41617f2d243a876a80e1
lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 320557bd092513af3f052466f115585df152f58d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 92717fee508bda112cd813f18ae6695acb484b66
lens-server/testdata/ClassLoaderTestClass.java PRE-CREATION
lens-server/testdata/ClassLoaderTestClass2.java PRE-CREATION
lens-server/testdata/test.jar PRE-CREATION
lens-server/testdata/test2.jar PRE-CREATION
src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
Diff: https://reviews.apache.org/r/31187/diff/
Testing (updated)
-------
1. Added unit tests for DatabaseResourceService
2. New unit tests related to class loading
3. Added new unit test in TestQueryService to verify that DB jars get passed to Hive driver before query is run
Will update latest test output.
Thanks,
Jaideep dhok