You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/08 20:39:05 UTC
[GitHub] [airflow] mariotaddeucci opened a new pull request #18844: Remove extra prostgres dependency
mariotaddeucci opened a new pull request #18844:
URL: https://github.com/apache/airflow/pull/18844
Removed postgres provider specific versions dependency generated on #18027.
Using the `RedshiftSQLHook ` introduced on #18447 and replicating the method `get_table_primary_key` to it.
The `get_table_primary_key` wasn't removed from `PostgresHook` because can be used on it.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #18844: Remove extra prostgres dependency from AWS Provider
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18844:
URL: https://github.com/apache/airflow/pull/18844#issuecomment-939264945
This one needs also similar change in `redshift_to_s3` and example dags @mariotaddeucci . Once you do it, you will see that the dependency betwen S3 and Postgres will be automatically removed (by pre-commit) from https://github.com/apache/airflow/blob/main/airflow/providers/dependencies.json (this is where we take cross-provider dependencies when we generate `setup.py` for providers. Only then the `[postgres]` extra will actually disappear from `amazon` provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18844: Remove extra postgres dependency from AWS Provider
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18844:
URL: https://github.com/apache/airflow/pull/18844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18844: Remove extra postgres dependency from AWS Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18844:
URL: https://github.com/apache/airflow/pull/18844#issuecomment-939521906
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #18844: Remove extra prostgres dependency from AWS Provider
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18844:
URL: https://github.com/apache/airflow/pull/18844#issuecomment-939264945
This one needs also similar change in `redshift_to_s3` and example dags @mariotaddeucci . Once you do it, you will see that the dependency betwen S3 and Postgres will be automatically removed (by pre-commit) from https://github.com/apache/airflow/blob/main/airflow/providers/dependencies.json (this is where we take cross-provider dependencies when we generate `setup.py` for providers).
Only then the `[postgres]` extra will actually disappear from `amazon` provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18844: Remove extra prostgres dependency from AWS Provider
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18844:
URL: https://github.com/apache/airflow/pull/18844#issuecomment-939184760
Re-triggering CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #18844: Remove extra prostgres dependency from AWS Provider
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #18844:
URL: https://github.com/apache/airflow/pull/18844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18844: Remove extra prostgres dependency from AWS Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18844:
URL: https://github.com/apache/airflow/pull/18844#issuecomment-939264945
This one needs also similar change in `redshift_to_s3` and example dags @mariotaddeucci . Once, if we do it, you will see that the dependency betwen S3 and Postgres will be automatically removed (by pre-commit) from https://github.com/apache/airflow/blob/main/airflow/providers/dependencies.json (this is where we take cross-provider dependencies when we generate `setup.py` for providers. Only then the `[postgres]` extra will actually disappear from `amazon` provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org