You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/27 15:08:16 UTC

[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #307: Revert "nshlib: remove the dependency of date on RTC"

patacongo edited a comment on pull request #307:
URL: https://github.com/apache/incubator-nuttx-apps/pull/307#issuecomment-650571924


   > 
   > 
   > It is strange if we still want to use the 'date' command to get the synchronized time from NTP server ... Seriously, not all of the devices include RTC modules.
   
   This is just the default setting.  It does not prevent you from selecting the option.  DO NOT CHANGE DEFAULT SETTINGS unless you also change all of the effected defconfig files.  That breaks configurations.
   
   Nothing is broken nothing should be fixed.  Adding NTP as an condition would be acceptable, but changing the default is just wrong.  Please do not do that.
   
   It is not wrong technically, it is wrong because it changes about 565 other configurations incorrectly.  That is what must be avoided.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org