You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/11 02:08:37 UTC

[GitHub] [doris] cambyzju opened a new pull request, #10747: [docs]fix typo in substring docs

cambyzju opened a new pull request, #10747:
URL: https://github.com/apache/doris/pull/10747

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   1. fix typo in docs/en/docs/sql-manual/sql-functions/string-functions/substring.md
   2. add another substring example with pos=0;
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   4. Has unit tests been added: (Yes/No/No Need)
   5. Has document been added or modified: (Yes/No/No Need)
   6. Does it need to update dependencies: (Yes/No)
   7. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] cambyzju commented on a diff in pull request #10747: [docs]fix typo in substring docs

Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10747:
URL: https://github.com/apache/doris/pull/10747#discussion_r917503982


##########
docs/en/docs/sql-manual/sql-functions/string-functions/substring.md:
##########
@@ -74,4 +82,4 @@ mysql> select substring('abc1def', 2, 2);
 ```
 
 ### keywords
-SUBSTRING
+SUBSTRING,STRING

Review Comment:
   done



##########
docs/zh-CN/docs/sql-manual/sql-functions/string-functions/substring.md:
##########
@@ -69,4 +76,4 @@ mysql> select substring('abc1def', 2, 2);
 +-----------------------------+
 ```
 ### keywords
-SUBSTRING
+SUBSTRING,STRING

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei merged pull request #10747: [docs]fix typo in substring docs

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10747:
URL: https://github.com/apache/doris/pull/10747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] jackwener commented on a diff in pull request #10747: [docs]fix typo in substring docs

Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #10747:
URL: https://github.com/apache/doris/pull/10747#discussion_r917503097


##########
docs/zh-CN/docs/sql-manual/sql-functions/string-functions/substring.md:
##########
@@ -69,4 +76,4 @@ mysql> select substring('abc1def', 2, 2);
 +-----------------------------+
 ```
 ### keywords
-SUBSTRING
+SUBSTRING,STRING

Review Comment:
   ```suggestion
   SUBSTRING, STRING
   ```



##########
docs/en/docs/sql-manual/sql-functions/string-functions/substring.md:
##########
@@ -74,4 +82,4 @@ mysql> select substring('abc1def', 2, 2);
 ```
 
 ### keywords
-SUBSTRING
+SUBSTRING,STRING

Review Comment:
   ```suggestion
   SUBSTRING, STRING
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org