You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/07 09:35:12 UTC

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r703348241



##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##########
@@ -249,7 +251,7 @@ public int maxFileOpeningThreads() {
 
     @Override
     public Options setMaxTotalWalSize(final long maxTotalWalSize) {
-        dbOptions.setMaxTotalWalSize(maxTotalWalSize);
+        LOGGER.warn("WAL is explicitly disabled by Streams in RocksDB. Setting option 'maxTotalWalSize' will be ignored");

Review comment:
       @cadonna 
   Sorry for the late reply, was on vacation.
   I added the rest of the wal options to the test. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org