[GitHub] [hbase] Apache9 commented on a diff in pull request #5281: HBASE-27923 NettyRpcServer may hange if it should skip initial sasl h…

["Apache9 (via GitHub)" <gi...@apache.org>]

Apache9 commented on code in PR #5281:
URL: https://github.com/apache/hbase/pull/5281#discussion_r1224075255


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java:
##########
@@ -125,7 +125,9 @@ protected void initChannel(Channel ch) throws Exception {
             initSSL(pipeline, conf.getBoolean(HBASE_SERVER_NETTY_TLS_SUPPORTPLAINTEXT, true));
           }
           pipeline.addLast(NettyRpcServerPreambleHandler.DECODER_NAME, preambleDecoder)
-            .addLast(createNettyRpcServerPreambleHandler());
+            .addLast(createNettyRpcServerPreambleHandler())
+            .addLast(NettyRpcServerResponseEncoder.HANDLER_NAME,

Review Comment:
   Better add some comments to say that why we need to add encoder here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org