You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/25 12:19:44 UTC
[GitHub] [shardingsphere-elasticjob] vran-dev opened a new issue #1415: code taste: unnecessary null check
vran-dev opened a new issue #1415:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1415
in class `JobScheduler`
```java
public JobScheduler(final CoordinatorRegistryCenter regCenter, final String elasticJobType, final JobConfiguration jobConfig, final TracingConfiguration<?> tracingConfig,
final ElasticJobListener... elasticJobListeners) {
this.regCenter = regCenter;
elasticJob = null;
// .......
jobExecutor = null == elasticJob ? new ElasticJobExecutor(elasticJobType, jobConfig, jobFacade) : new ElasticJobExecutor(elasticJob, jobConfig, jobFacade);
// ......
jobScheduleController = createJobScheduleController();
}
```
`null == elasticJob` is unnecessary, because elasticJob is always null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- closed issue #1415: Remove unnecessary null check
Posted by GitBox <gi...@apache.org>.
Technoboy- closed issue #1415:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org