You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "HubQin (via GitHub)" <gi...@apache.org> on 2023/08/24 07:53:32 UTC

[GitHub] [dubbo-go] HubQin commented on a diff in pull request #2387: feat: optimize the integration of otel tracing

HubQin commented on code in PR #2387:
URL: https://github.com/apache/dubbo-go/pull/2387#discussion_r1303945786


##########
imports/imports.go:
##########
@@ -66,6 +66,10 @@ import (
 	_ "dubbo.apache.org/dubbo-go/v3/metadata/service/remote"
 	_ "dubbo.apache.org/dubbo-go/v3/metrics/app_info"
 	_ "dubbo.apache.org/dubbo-go/v3/metrics/prometheus"
+	_ "dubbo.apache.org/dubbo-go/v3/otel/trace/jaeger"
+	_ "dubbo.apache.org/dubbo-go/v3/otel/trace/zipkin"
+	//_ "dubbo.apache.org/dubbo-go/v3/otel/trace/otlp" // FIXME: otlp-grpc use grpc health check which has the namespace conflict with dubbo3 protocol

Review Comment:
   May be fixed by #2395



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org