[jira] [Closed] (OFBIZ-5667) StringUtil api tests broken by 1330995

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5667.
----------------------------------


Adam,

I don't remember exactly, and I don't have access anymore to the svn repo (customer's project). This is one of the cases Git proves it's superior .

I reviewed the changes I did at r1212673, r1212749 and r1330995. It seems I was overtired when I wrote this sentence in my r1330995 comment:
{quote}
I changed the default separator from "|" in some intermediary methods to null which was the default before my changes in r1212749.
{quote}
This sentence does not make any sense (even to me :D ), I never replaced a null by a "|" in r1212749.

After checking again r1330995 changes, I believe you were right to revert the 2 you did in r1605268
I must have confused with this comment then
{code}
* @param delim the delimiter character(s) to join on (null will split on whitespace)
{code}


This also when Junit test cases proves their importance, thanks!

> StringUtil api tests broken by 1330995
> --------------------------------------
>
>                 Key: OFBIZ-5667
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5667
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 13.07
>            Reporter: Adam Heath
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>
> Go to framework/base.  Run "../../ant tests".  The StringUtil test case fails, it can't parse the string "1=one|2=two".  This is due to a break introduced in r1330995.
> You'll need the recent changes in trunk that fix command-line junit/cobertura tests(r1605121).



--
This message was sent by Atlassian JIRA
(v6.2#6252)