[GitHub] [thrift] slachiewicz commented on a diff in pull request #2779: java lib and build tool chain: gradle 8.0.2 and JDK 19

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz commented on code in PR #2779:
URL: https://github.com/apache/thrift/pull/2779#discussion_r1163389431


##########
.github/workflows/build.yml:
##########
@@ -137,14 +137,14 @@ jobs:
     needs: compiler
     runs-on: ubuntu-20.04
     env:
-      GRADLE_VERSION: "7.6"
+      GRADLE_VERSION: "8.0.2"
     steps:
       - uses: actions/checkout@v3
 
       - uses: actions/setup-java@v3
         with:
           distribution: temurin
-          java-version: 17
+          java-version: 19

Review Comment:
   this is to check if we are prepared to run build/tests with upcoming releases.
   I would recommend to use 20 here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org