You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/06 11:13:43 UTC
[GitHub] [shardingsphere] soulasuna opened a new pull request, #20836: Optimize unLock of LockPersistService in cluster mode
soulasuna opened a new pull request, #20836:
URL: https://github.com/apache/shardingsphere/pull/20836
## Optimize unLock of LockPersistService in cluster mode
Related #22035.
Changes proposed in this pull request:
- Optimize unLock of LockPersistService in cluster mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #20836: Optimize unLock of LockPersistService in cluster mode
Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #20836:
URL: https://github.com/apache/shardingsphere/pull/20836#issuecomment-1238843624
The CI error was fixed on master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 merged pull request #20836: Optimize unLock of LockPersistService in cluster mode
Posted by GitBox <gi...@apache.org>.
zhaojinchao95 merged PR #20836:
URL: https://github.com/apache/shardingsphere/pull/20836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20836: Optimize unLock of LockPersistService in cluster mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20836:
URL: https://github.com/apache/shardingsphere/pull/20836#issuecomment-1238396720
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20836](https://codecov.io/gh/apache/shardingsphere/pull/20836?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44a4359) into [master](https://codecov.io/gh/apache/shardingsphere/commit/50ae15890a00d89f3799a63279f6ceeb95d032b0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50ae158) will **increase** coverage by `0.04%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #20836 +/- ##
============================================
+ Coverage 61.43% 61.47% +0.04%
- Complexity 2423 2429 +6
============================================
Files 3999 3999
Lines 55329 55351 +22
Branches 9401 9404 +3
============================================
+ Hits 33989 34029 +40
+ Misses 18454 18437 -17
+ Partials 2886 2885 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cluster/coordinator/ClusterLockPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9DbHVzdGVyTG9ja1BlcnNpc3RTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/mode/repository/cluster/etcd/EtcdRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5L3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5LWV0Y2Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9jbHVzdGVyL2V0Y2QvRXRjZFJlcG9zaXRvcnkuamF2YQ==) | `69.64% <0.00%> (-2.58%)` | :arrow_down: |
| [.../cluster/zookeeper/CuratorZookeeperRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5L3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5LXpvb2tlZXBlci1jdXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL3JlcG9zaXRvcnkvY2x1c3Rlci96b29rZWVwZXIvQ3VyYXRvclpvb2tlZXBlclJlcG9zaXRvcnkuamF2YQ==) | `55.73% <0.00%> (-0.93%)` | :arrow_down: |
| [...er/zookeeper/lock/ZookeeperInternalLockHolder.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5L3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1yZXBvc2l0b3J5LXpvb2tlZXBlci1jdXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL3JlcG9zaXRvcnkvY2x1c3Rlci96b29rZWVwZXIvbG9jay9ab29rZWVwZXJJbnRlcm5hbExvY2tIb2xkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...loader/dialect/PostgreSQLSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvUG9zdGdyZVNRTFNjaGVtYU1ldGFEYXRhTG9hZGVyLmphdmE=) | `82.90% <0.00%> (+1.08%)` | :arrow_up: |
| [...t/sqlserver/ddl/SQLServerCreateTableStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvc3Fsc2VydmVyL2RkbC9TUUxTZXJ2ZXJDcmVhdGVUYWJsZVN0YXRlbWVudC5qYXZh) | `100.00% <0.00%> (+33.33%)` | :arrow_up: |
| [...alect/handler/ddl/CreateTableStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RkbC9DcmVhdGVUYWJsZVN0YXRlbWVudEhhbmRsZXIuamF2YQ==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
| [...dialect/handler/ddl/AlterViewStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RkbC9BbHRlclZpZXdTdGF0ZW1lbnRIYW5kbGVyLmphdmE=) | `100.00% <0.00%> (+50.00%)` | :arrow_up: |
| [...l/dialect/handler/dal/ExplainStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RhbC9FeHBsYWluU3RhdGVtZW50SGFuZGxlci5qYXZh) | `100.00% <0.00%> (+66.66%)` | :arrow_up: |
| [...arser/sql/common/statement/dal/FlushStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kYWwvRmx1c2hTdGF0ZW1lbnQuamF2YQ==) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/shardingsphere/pull/20836/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #20836: Optimize unLock of LockPersistService in cluster mode
Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #20836:
URL: https://github.com/apache/shardingsphere/pull/20836#issuecomment-1238773853
There's error in JDK 18 CI:
```
Error: DMLShardingConditionsShardingAuditAlgorithmTest.assertAllBroadcastTablesCheck:73 ClassCast
Error: DMLShardingConditionsShardingAuditAlgorithmTest.assertEmptyShardingConditionsCheck:89 ClassCast
Error: DMLShardingConditionsShardingAuditAlgorithmTest.assertNotAllShardingTablesCheck:81 ClassCast
Error: assertEmptyShardingConditionsCheck(org.apache.shardingsphere.sharding.algorithm.audit.DMLShardingConditionsShardingAuditAlgorithmTest) Time elapsed: 0.001 s <<< ERROR!
java.lang.ClassCastException: class org.apache.shardingsphere.infra.rule.ShardingSphereRule$MockitoMock$va6l5Unp cannot be cast to class org.apache.shardingsphere.sharding.rule.ShardingRule (org.apache.shardingsphere.infra.rule.ShardingSphereRule$MockitoMock$va6l5Unp and org.apache.shardingsphere.sharding.rule.ShardingRule are in unnamed module of loader 'app')
at org.apache.shardingsphere.sharding.algorithm.audit.DMLShardingConditionsShardingAuditAlgorithmTest.assertEmptyShardingConditionsCheck(DMLShardingConditionsShardingAuditAlgorithmTest.java:89)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org