You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by sv...@apache.org on 2018/09/19 04:00:05 UTC

svn commit: r1841281 - in /subversion/branches/1.10.x: ./ STATUS subversion/mod_dav_svn/repos.c

Author: svn-role
Date: Wed Sep 19 04:00:05 2018
New Revision: 1841281

URL: http://svn.apache.org/viewvc?rev=1841281&view=rev
Log:
Merge r1833465 from trunk:

 * r1833465
   Enforce the v1 HTTP protocol when a client sends PUT before CHECKOUT.
   Justification:
     Return an error when the client gets our v1 protocol wrong.
   Votes:
     +1: philip, jamessan, rhuijben

Modified:
    subversion/branches/1.10.x/   (props changed)
    subversion/branches/1.10.x/STATUS
    subversion/branches/1.10.x/subversion/mod_dav_svn/repos.c

Propchange: subversion/branches/1.10.x/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Sep 19 04:00:05 2018
@@ -101,4 +101,4 @@
 /subversion/branches/verify-at-commit:1462039-1462408
 /subversion/branches/verify-keep-going:1439280-1546110
 /subversion/branches/wc-collate-path:1402685-1480384
-/subversion/trunk:1817837,1817856,1818577-1818578,1818584,1818651,1818662,1818727,1818801,1818803,1818807,1818868,1818871,1819036-1819037,1819043,1819049,1819052,1819093,1819146,1819162,1819444,1819556-1819557,1819603,1819804,1819911,1820044,1820046-1820047,1820518,1820627,1820718,1820778,1821183,1821224,1821621,1821678,1822401,1822587,1822591,1822996,1823202-1823203,1823211,1823327,1823791,1823966,1823989,1824033,1825024,1825045,1825215,1825266,1825306,1825709,1825711,1825721,1825736,1825778,1825783,1825787-1825788,1825979,1826720-1826721,1826747,1826811,1826814,1826877,1826907,1826971,1827105,1827114,1827191,1827562,1827574,1827670,1828613,1829012,1829015,1829241,1829260,1829344,1830083,1830882-1830883,1830885,1830900-1830901,1831110,1831112,1831540,1833621,1833836,1833842,1833864,1833866,1833895,1833897,1833899,1833901,1835760,1837037
+/subversion/trunk:1817837,1817856,1818577-1818578,1818584,1818651,1818662,1818727,1818801,1818803,1818807,1818868,1818871,1819036-1819037,1819043,1819049,1819052,1819093,1819146,1819162,1819444,1819556-1819557,1819603,1819804,1819911,1820044,1820046-1820047,1820518,1820627,1820718,1820778,1821183,1821224,1821621,1821678,1822401,1822587,1822591,1822996,1823202-1823203,1823211,1823327,1823791,1823966,1823989,1824033,1825024,1825045,1825215,1825266,1825306,1825709,1825711,1825721,1825736,1825778,1825783,1825787-1825788,1825979,1826720-1826721,1826747,1826811,1826814,1826877,1826907,1826971,1827105,1827114,1827191,1827562,1827574,1827670,1828613,1829012,1829015,1829241,1829260,1829344,1830083,1830882-1830883,1830885,1830900-1830901,1831110,1831112,1831540,1833465,1833621,1833836,1833842,1833864,1833866,1833895,1833897,1833899,1833901,1835760,1837037

Modified: subversion/branches/1.10.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.10.x/STATUS?rev=1841281&r1=1841280&r2=1841281&view=diff
==============================================================================
--- subversion/branches/1.10.x/STATUS (original)
+++ subversion/branches/1.10.x/STATUS Wed Sep 19 04:00:05 2018
@@ -100,13 +100,6 @@ Veto-blocked changes:
 Approved changes:
 =================
 
- * r1833465
-   Enforce the v1 HTTP protocol when a client sends PUT before CHECKOUT.
-   Justification:
-     Return an error when the client gets our v1 protocol wrong.
-   Votes:
-     +1: philip, jamessan, rhuijben
-
  * r1836306
    Ignore stat() reporting size zero when reading from pipe/fifo.
    Justification:

Modified: subversion/branches/1.10.x/subversion/mod_dav_svn/repos.c
URL: http://svn.apache.org/viewvc/subversion/branches/1.10.x/subversion/mod_dav_svn/repos.c?rev=1841281&r1=1841280&r2=1841281&view=diff
==============================================================================
--- subversion/branches/1.10.x/subversion/mod_dav_svn/repos.c (original)
+++ subversion/branches/1.10.x/subversion/mod_dav_svn/repos.c Wed Sep 19 04:00:05 2018
@@ -2861,6 +2861,13 @@ open_stream(const dav_resource *resource
                                     "Resource body changes may only be made to "
                                     "working resources (at this time).");
         }
+      if (!resource->info->root.root)
+        {
+          return dav_svn__new_error(resource->pool, HTTP_METHOD_NOT_ALLOWED,
+                                    0, 0,
+                                    "Resource body changes may only be made to "
+                                    "checked-out resources (at this time).");
+        }
     }
 
   /* ### TODO:  Can we support range writes someday? */