You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/10 12:21:20 UTC

[GitHub] [flink] dawidwys commented on issue #9050: [FLINK-13181][Table]Add Builder to build CsvTableSink instances

dawidwys commented on issue #9050: [FLINK-13181][Table]Add Builder to build CsvTableSink instances
URL: https://github.com/apache/flink/pull/9050#issuecomment-573014543
 
 
   Hi @hehuiyuan,
   Could you rebase the change to the current master?
   
   Moreover I don't think we need a whole IT case for testing that a builder sets all properties correctly. Could you change the test to a unit test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services