You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dan-s1 (via GitHub)" <gi...@apache.org> on 2026/05/15 21:47:34 UTC
[PR] NIFI-15947 Replaced deprecated method expireAfterWrite of com.google.common.cache.CacheBuilder. [nifi]
dan-s1 opened a new pull request, #11258:
URL: https://github.com/apache/nifi/pull/11258
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-15947](https://issues.apache.org/jira/browse/NIFI-15947)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
- Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
### Pull Request Formatting
- Pull Request based on current revision of the `main` branch
- Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15947 Replaced deprecated method expireAfterWrite of com.google.common.cache.CacheBuilder. [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on code in PR #11258:
URL: https://github.com/apache/nifi/pull/11258#discussion_r3252652053
##########
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/oidc/OidcService.java:
##########
@@ -296,4 +298,16 @@ private boolean timeConstantEqualityCheck(final String value1, final String valu
return MessageDigest.isEqual(value1.getBytes(StandardCharsets.UTF_8), value2.getBytes(StandardCharsets.UTF_8));
}
+
+ private Duration getDuration(long duration, TimeUnit unit) {
+ return switch (unit) {
+ case DAYS -> Duration.ofDays(duration);
+ case HOURS -> Duration.ofHours(duration);
+ case MICROSECONDS -> Duration.ofMillis(TimeUnit.MILLISECONDS.convert(duration, TimeUnit.MICROSECONDS));
Review Comment:
In the `MICROSECONDS` branch, the conversion goes through `TimeUnit.MILLISECONDS.convert(...)`, which truncates a sub-millisecond input to zero and would make the cache expire immediately. Is that loss of precision intentional?
##########
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/oidc/OidcService.java:
##########
@@ -296,4 +298,16 @@ private boolean timeConstantEqualityCheck(final String value1, final String valu
return MessageDigest.isEqual(value1.getBytes(StandardCharsets.UTF_8), value2.getBytes(StandardCharsets.UTF_8));
}
+
+ private Duration getDuration(long duration, TimeUnit unit) {
Review Comment:
Could `getDuration` be replaced with a single call to `Duration.of(duration, unit.toChronoUnit())`, which handles every `TimeUnit` value correctly and removes the need for a helper method?
##########
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/oidc/OidcService.java:
##########
@@ -296,4 +298,16 @@ private boolean timeConstantEqualityCheck(final String value1, final String valu
return MessageDigest.isEqual(value1.getBytes(StandardCharsets.UTF_8), value2.getBytes(StandardCharsets.UTF_8));
}
+
+ private Duration getDuration(long duration, TimeUnit unit) {
Review Comment:
Should the `duration` and `unit` parameters be declared `final` to match the NiFi code style and the rest of this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15947 Replaced deprecated method expireAfterWrite of com.google.common.cache.CacheBuilder. [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 merged PR #11258:
URL: https://github.com/apache/nifi/pull/11258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15947 Replaced deprecated method expireAfterWrite of com.google.common.cache.CacheBuilder. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on code in PR #11258:
URL: https://github.com/apache/nifi/pull/11258#discussion_r3260912886
##########
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/oidc/OidcService.java:
##########
@@ -296,4 +298,16 @@ private boolean timeConstantEqualityCheck(final String value1, final String valu
return MessageDigest.isEqual(value1.getBytes(StandardCharsets.UTF_8), value2.getBytes(StandardCharsets.UTF_8));
}
+
+ private Duration getDuration(long duration, TimeUnit unit) {
Review Comment:
Great point! I did not realize that existed.
I assume with this, the rest of the comments are OBE as I no longer need the `getDuration` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org