You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/09/22 14:59:56 UTC
[GitHub] [accumulo-testing] DomGarguilo opened a new pull request #156: Add units to performance test results
DomGarguilo opened a new pull request #156:
URL: https://github.com/apache/accumulo-testing/pull/156
Fixes #23
* Added "units" parameter to report.java and result.java which adds units to the test output (JSON)
* Updated all usages of report.java and result.java to comply with new parameter
<details>
<summary>Current output, without units</summary>
```JSON
{
"testClass": "org.apache.accumulo.testing.performance.tests.DurabilityWriteSpeedPT",
"accumuloVersion": "2.1.0-SNAPSHOT",
"startTime": "2021-09-22T12:38:32.950553Z",
"finishTime": "2021-09-22T12:39:20.304474Z",
"id": "durability",
"description": "Compares writes speeds at different durability levels",
"results": [
{
"id": "sync attempt 0",
"data": 3984,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync attempt 1",
"data": 3490,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync attempt 2",
"data": 3726,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync attempt 3",
"data": 3320,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync attempt 4",
"data": 3696,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync Median",
"data": 3696,
"description": "Median time result for sync",
"purpose": "COMPARISON"
},
{
"id": "flush attempt 0",
"data": 2527,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush attempt 1",
"data": 896,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush attempt 2",
"data": 986,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush attempt 3",
"data": 1228,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush attempt 4",
"data": 908,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush Median",
"data": 986,
"description": "Median time result for flush",
"purpose": "COMPARISON"
},
{
"id": "log attempt 0",
"data": 2852,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log attempt 1",
"data": 851,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log attempt 2",
"data": 1090,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log attempt 3",
"data": 1048,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log attempt 4",
"data": 901,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log Median",
"data": 1048,
"description": "Median time result for log",
"purpose": "COMPARISON"
},
{
"id": "none attempt 0",
"data": 2569,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none attempt 1",
"data": 755,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none attempt 2",
"data": 755,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none attempt 3",
"data": 729,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none attempt 4",
"data": 866,
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none Median",
"data": 755,
"description": "Median time result for none",
"purpose": "COMPARISON"
}
],
"parameters": [
{
"id": "rows",
"data": "100000",
"description": "Number of random rows written."
}
]
}
```
</details>
<details>
<summary>New output, with units</summary>
```JSON
{
"testClass": "org.apache.accumulo.testing.performance.tests.DurabilityWriteSpeedPT",
"accumuloVersion": "2.1.0-SNAPSHOT",
"startTime": "2021-09-22T14:42:37.823125Z",
"finishTime": "2021-09-22T14:43:24.283933Z",
"id": "durability",
"description": "Compares writes speeds at different durability levels",
"results": [
{
"id": "sync attempt 0",
"data": 3722,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync attempt 1",
"data": 2925,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync attempt 2",
"data": 3528,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync attempt 3",
"data": 3712,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync attempt 4",
"data": 3674,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "sync Median",
"data": 3674,
"units": "MILLISECONDS",
"description": "Median time result for sync",
"purpose": "COMPARISON"
},
{
"id": "flush attempt 0",
"data": 2903,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush attempt 1",
"data": 897,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush attempt 2",
"data": 993,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush attempt 3",
"data": 1240,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush attempt 4",
"data": 1021,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "flush Median",
"data": 1021,
"units": "MILLISECONDS",
"description": "Median time result for flush",
"purpose": "COMPARISON"
},
{
"id": "log attempt 0",
"data": 2843,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log attempt 1",
"data": 888,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log attempt 2",
"data": 831,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log attempt 3",
"data": 863,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log attempt 4",
"data": 856,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "log Median",
"data": 863,
"units": "MILLISECONDS",
"description": "Median time result for log",
"purpose": "COMPARISON"
},
{
"id": "none attempt 0",
"data": 2557,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none attempt 1",
"data": 791,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none attempt 2",
"data": 783,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none attempt 3",
"data": 791,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none attempt 4",
"data": 804,
"units": "MILLISECONDS",
"description": "Times for each attempt in ms",
"purpose": "INFORMATIONAL"
},
{
"id": "none Median",
"data": 791,
"units": "MILLISECONDS",
"description": "Median time result for none",
"purpose": "COMPARISON"
}
],
"parameters": [
{
"id": "rows",
"data": "100000",
"description": "Number of random rows written."
}
]
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo commented on pull request #156: Add units to performance test results
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on pull request #156:
URL: https://github.com/apache/accumulo-testing/pull/156#issuecomment-925094967
> Slightly unrelated, have you run all these PTs to verify they still work as expected?
Not all of the tests seem to be in running order, but all of the tests that I could get to run, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] Manno15 commented on pull request #156: Add units to performance test results
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #156:
URL: https://github.com/apache/accumulo-testing/pull/156#issuecomment-926023301
>I was considering that as well. I'll go ahead and update the descriptions.
It might not be worth the trouble. So up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] Manno15 commented on pull request #156: Add units to performance test results
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #156:
URL: https://github.com/apache/accumulo-testing/pull/156#issuecomment-925070441
Slightly unrelated, have you run all these PTs to verify they still work as expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo merged pull request #156: Add units to performance test results
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged pull request #156:
URL: https://github.com/apache/accumulo-testing/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo commented on pull request #156: Add units to performance test results
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on pull request #156:
URL: https://github.com/apache/accumulo-testing/pull/156#issuecomment-926019226
> Changes look good. My only possible suggestion is some of the descriptions do not need the unit in them anymore with the unit being given separately. Not a huge deal
I was considering that as well. I'll go ahead and update the descriptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org