You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2014/10/18 00:35:16 UTC

[GitHub] incubator-flink pull request: [FLINK-933] Add primitive input form...

Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/47#issuecomment-59585244
  
    Looks good. I think the input format can be merged. For the Data set methods, we should have a few comments (they are core api, so must be kept stable once added.)
    
    From my side: How hard would it be to allow for strings as delimiters, rather than just single characters?
    
    Also: I think the tests are failing, because they detect the Java and Scala API being out of sync.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---