You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2010/12/30 18:18:28 UTC
svn commit: r1053945 - in /subversion/trunk/subversion/bindings/javahl:
src/org/apache/subversion/javahl/ISVNClient.java
src/org/apache/subversion/javahl/SVNClient.java
tests/org/apache/subversion/javahl/BasicTests.java
Author: hwright
Date: Thu Dec 30 17:18:28 2010
New Revision: 1053945
URL: http://svn.apache.org/viewvc?rev=1053945&view=rev
Log:
JavaHL: Remove the quite superfluous propertyCreate() API.
[ in subversion/bindings/javahl/ ]
* tests/org/apache/subversion/javahl/BasicTests.java:
Switch callers to propertySet().
* src/org/apache/subversion/javahl/SVNClient.java,
src/org/apache/subversion/javahl/ISVNClient.java
(propertyCreate): Remove (with prejudice).
Modified:
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ISVNClient.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/SVNClient.java
subversion/trunk/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ISVNClient.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ISVNClient.java?rev=1053945&r1=1053944&r2=1053945&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ISVNClient.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ISVNClient.java Thu Dec 30 17:18:28 2010
@@ -699,28 +699,6 @@ public interface ISVNClient
throws ClientException;
/**
- * Create and sets one property of an item with a byte array value
- *
- * @param path path of the item
- * @param name name of the property
- * @param value new value of the property
- * @param depth depth to set property on the subdirectories
- * @param changelists changelists to filter by
- * @param force do not check if the value is valid
- * @throws ClientException
- * @since 1.5
- */
- void propertyCreate(String path, String name, byte[] value, Depth depth,
- Collection<String> changelists, boolean force,
- CommitCallback callback)
- throws ClientException;
-
- void propertyCreate(String path, String name, String value, Depth depth,
- Collection<String> changelists, boolean force,
- CommitCallback callback)
- throws ClientException;
-
- /**
* Retrieve one revsision property of one item
* @param path path of the item
* @param name name of the property
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/SVNClient.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/SVNClient.java?rev=1053945&r1=1053944&r2=1053945&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/SVNClient.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/SVNClient.java Thu Dec 30 17:18:28 2010
@@ -446,27 +446,6 @@ public class SVNClient implements ISVNCl
}
/**
- * @since 1.5
- */
- public void propertyCreate(String path, String name, byte[] value,
- Depth depth, Collection<String> changelists,
- boolean force, CommitCallback callback)
- throws ClientException
- {
- propertySet(path, name, value, depth, changelists, force, null,
- callback);
- }
-
- public void propertyCreate(String path, String name, String value,
- Depth depth, Collection<String> changelists,
- boolean force, CommitCallback callback)
- throws ClientException
- {
- propertySet(path, name, value, depth, changelists, force, null,
- callback);
- }
-
- /**
* @since 1.0
*/
public native byte[] revProperty(String path, String name, Revision rev)
Modified: subversion/trunk/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java?rev=1053945&r1=1053944&r2=1053945&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java (original)
+++ subversion/trunk/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java Thu Dec 30 17:18:28 2010
@@ -703,8 +703,8 @@ public class BasicTests extends SVNTests
"/A/B/E/alpha"),
false);
String alphaVal = "qrz";
- client.propertyCreate(itemPath, "cqcq", alphaVal.getBytes(), Depth.empty, null,
- false, null);
+ client.propertySet(itemPath, "cqcq", alphaVal.getBytes(), Depth.empty,
+ null, false, null, null);
final Map<String, Map<String, byte[]>> propMaps =
new HashMap<String, Map<String, byte[]>>();
@@ -2796,8 +2796,8 @@ public class BasicTests extends SVNTests
if (operativeRevision == 2) {
// Set svn:eol-style=native on iota
- client.propertyCreate(iotaPath, "svn:eol-style", "native",
- Depth.empty, null, false, null);
+ client.propertySet(iotaPath, "svn:eol-style", "native",
+ Depth.empty, null, false, null, null);
Set<String> paths = new HashSet<String>(1);
paths.add(iotaPath);
addExpectedCommitItem(thisTest.getWCPath(),