You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/17 03:42:02 UTC

[GitHub] [incubator-inlong] justinwwhuang opened a new pull request #2543: [INLONG-2540][agent] create db sql collect task by config from manager

justinwwhuang opened a new pull request #2543:
URL: https://github.com/apache/incubator-inlong/pull/2543


   ### Title Name: [INLONG-2540][component] Title of the pull request
   
   Fixes #<2540>
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] EMsnap commented on a change in pull request #2543: [INLONG-2540][Agent] Create db sql collect task by config from manager

Posted by GitBox <gi...@apache.org>.
EMsnap commented on a change in pull request #2543:
URL: https://github.com/apache/incubator-inlong/pull/2543#discussion_r809939104



##########
File path: inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/fetcher/dtos/JobProfileDto.java
##########
@@ -36,7 +36,7 @@
     public static final String DEFAULT_CHANNEL = "org.apache.inlong.agent.plugin.channel.MemoryChannel";
     public static final String MANAGER_JOB = "MANAGER_JOB";
     public static final String DEFAULT_DATAPROXY_SINK = "org.apache.inlong.agent.plugin.sinks.ProxySink";
-    public static final String DEFAULT_SOURCE = "org.apache.inlong.agent.plugin.sources.TextFileSource";
+    public static final String DEFAULT_SOURCE = "org.apache.inlong.agent.plugin.sources.DataBaseSource";

Review comment:
       DatabaseSqlSource could be better, since there will be DatabaseBinlog source




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang merged pull request #2543: [INLONG-2540][Agent] Create db sql collect task by config from manager

Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2543:
URL: https://github.com/apache/incubator-inlong/pull/2543


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] justinwwhuang commented on a change in pull request #2543: [INLONG-2540][Agent] Create db sql collect task by config from manager

Posted by GitBox <gi...@apache.org>.
justinwwhuang commented on a change in pull request #2543:
URL: https://github.com/apache/incubator-inlong/pull/2543#discussion_r810005132



##########
File path: inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/fetcher/dtos/JobProfileDto.java
##########
@@ -36,7 +36,7 @@
     public static final String DEFAULT_CHANNEL = "org.apache.inlong.agent.plugin.channel.MemoryChannel";
     public static final String MANAGER_JOB = "MANAGER_JOB";
     public static final String DEFAULT_DATAPROXY_SINK = "org.apache.inlong.agent.plugin.sinks.ProxySink";
-    public static final String DEFAULT_SOURCE = "org.apache.inlong.agent.plugin.sources.TextFileSource";
+    public static final String DEFAULT_SOURCE = "org.apache.inlong.agent.plugin.sources.DataBaseSource";

Review comment:
       get




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org