You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/02 16:18:13 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2418: Allow subqueries without aliases
andygrove opened a new pull request, #2418:
URL: https://github.com/apache/arrow-datafusion/pull/2418
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/2417
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I am trying to run some ANSI SQL that works fine in Apache Spark but fails in DataFusion because we currently require subqueries to have aliases.
As described in the [issue](https://github.com/apache/arrow-datafusion/issues/2417) though, Postgres *does* require subqueries to be aliased, so that is probably what determined the current behavior?
Should we make this behavior configurable?
There was a discussion about this in https://github.com/apache/arrow-datafusion/pull/1067
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Remove the check that caused subqueries without aliases to fail. Note that there were no tests for this functionality.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2418: Allow subqueries without aliases
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2418:
URL: https://github.com/apache/arrow-datafusion/pull/2418#discussion_r863218370
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -925,6 +925,38 @@ async fn csv_select_nested() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn csv_select_nested_without_aliases() -> Result<()> {
+ let ctx = SessionContext::new();
+ register_aggregate_csv(&ctx).await?;
+ let sql = "SELECT o1, o2, c3
+ FROM (
+ SELECT c1 AS o1, c2 + 1 AS o2, c3
+ FROM (
+ SELECT c1, c2, c3, c4
+ FROM aggregate_test_100
+ WHERE c1 = 'a' AND c2 >= 4
+ ORDER BY c2 ASC, c3 ASC
+ )
+ )";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec![
+ "+----+----+------+",
+ "| o1 | o2 | c3 |",
+ "+----+----+------+",
+ "| a | 5 | -101 |",
+ "| a | 5 | -54 |",
+ "| a | 5 | -38 |",
+ "| a | 5 | 65 |",
+ "| a | 6 | -101 |",
+ "| a | 6 | -31 |",
+ "| a | 6 | 36 |",
+ "+----+----+------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+ Ok(())
+}
+
Review Comment:
Awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2418: Allow subqueries without aliases
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #2418:
URL: https://github.com/apache/arrow-datafusion/pull/2418#discussion_r863134045
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -925,6 +925,38 @@ async fn csv_select_nested() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn csv_select_nested_without_aliases() -> Result<()> {
+ let ctx = SessionContext::new();
+ register_aggregate_csv(&ctx).await?;
+ let sql = "SELECT o1, o2, c3
+ FROM (
+ SELECT c1 AS o1, c2 + 1 AS o2, c3
+ FROM (
+ SELECT c1, c2, c3, c4
+ FROM aggregate_test_100
+ WHERE c1 = 'a' AND c2 >= 4
+ ORDER BY c2 ASC, c3 ASC
+ )
+ )";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec![
+ "+----+----+------+",
+ "| o1 | o2 | c3 |",
+ "+----+----+------+",
+ "| a | 5 | -101 |",
+ "| a | 5 | -54 |",
+ "| a | 5 | -38 |",
+ "| a | 5 | 65 |",
+ "| a | 6 | -101 |",
+ "| a | 6 | -31 |",
+ "| a | 6 | 36 |",
+ "+----+----+------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+ Ok(())
+}
+
Review Comment:
Thanks for the review @alamb. I added the suggested test and did not run into problems so will go ahead and merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2418: Allow subqueries without aliases
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2418:
URL: https://github.com/apache/arrow-datafusion/pull/2418#issuecomment-1115087037
@alamb @yjshen @xudong963 @houqp How do you think we should handle this? Should I consider enabling this or not based on the SQL dialect being used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #2418: Allow subqueries without aliases
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2418:
URL: https://github.com/apache/arrow-datafusion/pull/2418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2418: Allow subqueries without aliases
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2418:
URL: https://github.com/apache/arrow-datafusion/pull/2418#discussion_r863057073
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -925,6 +925,38 @@ async fn csv_select_nested() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn csv_select_nested_without_aliases() -> Result<()> {
+ let ctx = SessionContext::new();
+ register_aggregate_csv(&ctx).await?;
+ let sql = "SELECT o1, o2, c3
+ FROM (
+ SELECT c1 AS o1, c2 + 1 AS o2, c3
+ FROM (
+ SELECT c1, c2, c3, c4
+ FROM aggregate_test_100
+ WHERE c1 = 'a' AND c2 >= 4
+ ORDER BY c2 ASC, c3 ASC
+ )
+ )";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec![
+ "+----+----+------+",
+ "| o1 | o2 | c3 |",
+ "+----+----+------+",
+ "| a | 5 | -101 |",
+ "| a | 5 | -54 |",
+ "| a | 5 | -38 |",
+ "| a | 5 | 65 |",
+ "| a | 6 | -101 |",
+ "| a | 6 | -31 |",
+ "| a | 6 | 36 |",
+ "+----+----+------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+ Ok(())
+}
+
Review Comment:
Maybe we could also add a test here that had two unaliased subqueries (should result in a cross join) as a potential other case that would be good to cover
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org