[GitHub] [arrow] eitsupi commented on a diff in pull request #13626: ARROW-8324: [R] Add read/write_ipc_file separate from _feather

[GitBox <gi...@apache.org>]

eitsupi commented on code in PR #13626:
URL: https://github.com/apache/arrow/pull/13626#discussion_r922766450


##########
r/R/feather.R:
##########
@@ -46,9 +48,14 @@
 #' @seealso [RecordBatchWriter] for lower-level access to writing Arrow IPC data.
 #' @seealso [Schema] for information about schemas and metadata handling.
 #' @examples
-#' tf <- tempfile()
-#' on.exit(unlink(tf))
-#' write_feather(mtcars, tf)
+#' tf1 <- tempfile(fileext = ".feather")
+#' tf2 <- tempfile(fileext = ".arrow")
+#' on.exit({
+#'   unlink(tf1)
+#'   unlink(tf2)
+#' })
+#' write_feather(mtcars, tf1, version = 1)
+#' write_ipc_file(mtcars, tf2)

Review Comment:
   I think it would be easier to understand if the pages were separated for each type of file to be read/write, as they are in their current state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org