You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ps-19 (via GitHub)" <gi...@apache.org> on 2023/03/22 11:46:05 UTC

[GitHub] [apisix-ingress-controller] ps-19 opened a new pull request, #1741: Issue 1182

ps-19 opened a new pull request, #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741

   <!-- Please answer these questions before submitting a pull request -->
   
   ### Type of change:
   
   <!-- Please delete options that are not relevant. -->
   
   <!-- Select all the options from below that matches the type your PR best -->
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   - [ ] Documentation
   - [ ] Refactor
   - [ ] Chore
   - [x] CI/CD or Tests
   
   ### What this PR does / why we need it:
   
   This PR adds functionality to require a certificate from a file, and also includes a certificate generation script. The purpose of this is to simplify the process of generating and using certificates in the application, by providing an automated way to generate new certificates as needed.
   
   With this PR, users of the application can simply provide the path to an existing certificate file, rather than having to generate a new certificate manually each time. In addition, the included certificate generation script makes it easy for developers to generate new certificates as needed, without having to manually create and configure them.
   
   Overall, this PR makes it easier to work with SSL/TLS certificates in the application, by simplifying the process of generating and using certificates. It provides an automated and standardized way to handle certificates, making the application more secure and reliable.
   
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the requirements:
   1. Use Draft if the PR is not ready to be reviewed
   2. Test is required for the feat/fix PR, unless you have a good reason
   3. Doc is required for the feat PR
   4. Use a new commit to resolve review instead of `push -f`
   5. Use "request review" to notify the reviewer once you have resolved the review
   -->
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [x] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #1741: e2e: require certificate from file and add certificate generation script

Posted by "lingsamuel (via GitHub)" <gi...@apache.org>.
lingsamuel commented on PR #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741#issuecomment-1502694304

   We don't need such a heavy component just for generating some simple test certificates. `openssl` can do everything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #1741: e2e: require certificate from file and add certificate generation script

Posted by "lingsamuel (via GitHub)" <gi...@apache.org>.
lingsamuel commented on PR #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741#issuecomment-1493978943

   The issue was intended to solve two problems: the large number of raw certificates in e2e is hard to read and understand, and there is no renewal mechanism.
   What I want is to add the renewal mechanism, which is equivalent to being able to dynamically generate new certificates every time you run e2e, so that the reader can understand the configuration by read the certificates' generation parameters.
   
   Therefore, instead of simply splitting the certificates into files, you should modify the CI workflow to dynamically generate these certificates.
   Also, the `keyCompare` should be modified too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-ingress-controller] ps-19 closed pull request #1741: e2e: require certificate from file and add certificate generation script

Posted by "ps-19 (via GitHub)" <gi...@apache.org>.
ps-19 closed pull request #1741: e2e: require certificate from file and add certificate generation script
URL: https://github.com/apache/apisix-ingress-controller/pull/1741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1741: Issue 1182

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741#issuecomment-1482126359

   ## [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1741?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1741](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1741?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b34bf0) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/97f6aed4c0b8279744bb480ddcc5d8c776d04258?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97f6aed) will **increase** coverage by `0.20%`.
   > The diff coverage is `68.88%`.
   
   > :exclamation: Current head 4b34bf0 differs from pull request most recent head 9a72d82. Consider uploading reports for the commit 9a72d82 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1741      +/-   ##
   ==========================================
   + Coverage   41.48%   41.69%   +0.20%     
   ==========================================
     Files          89       90       +1     
     Lines        7667     7702      +35     
   ==========================================
   + Hits         3181     3211      +30     
   - Misses       4122     4127       +5     
     Partials      364      364              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/providers/gateway/translation/gateway.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9nYXRld2F5L3RyYW5zbGF0aW9uL2dhdGV3YXkuZ28=) | `0.00% <0.00%> (ø)` | |
   | [...providers/gateway/translation/gateway\_httproute.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9nYXRld2F5L3RyYW5zbGF0aW9uL2dhdGV3YXlfaHR0cHJvdXRlLmdv) | `48.38% <ø> (ø)` | |
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `83.05% <100.00%> (+0.14%)` | :arrow_up: |
   | [pkg/providers/utils/domain.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy91dGlscy9kb21haW4uZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/providers/utils/string.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy91dGlscy9zdHJpbmcuZ28=) | `26.08% <100.00%> (+26.08%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-ingress-controller] ps-19 commented on pull request #1741: e2e: require certificate from file and add certificate generation script

Posted by "ps-19 (via GitHub)" <gi...@apache.org>.
ps-19 commented on PR #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741#issuecomment-1498673538

   kubectl apply -f certificate.yaml
   
   kubectl get secret example-tls -o jsonpath='{.data.tls\.crt}' | base64 -d
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-ingress-controller] ps-19 commented on pull request #1741: e2e: require certificate from file and add certificate generation script

Posted by "ps-19 (via GitHub)" <gi...@apache.org>.
ps-19 commented on PR #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741#issuecomment-1498671774

   Can I use cert-manager?
   
   ```
   
   apiVersion: cert-manager.io/v1alpha2
   kind: Certificate
   metadata:
     name: example-cert
   spec:
     secretName: example-tls
     duration: 2160h
     renewBefore: 360h
     commonName: api7.com
     dnsNames:
       - api7.com
     issuerRef:
       name: letsencrypt
       kind: ClusterIssuer
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-ingress-controller] ps-19 commented on pull request #1741: e2e: require certificate from file and add certificate generation script

Posted by "ps-19 (via GitHub)" <gi...@apache.org>.
ps-19 commented on PR #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741#issuecomment-1498672247

   https://cert-manager.io/docs/reference/api-docs/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1741: Issue 1182

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741#issuecomment-1482208998

   @ps-19 please check the CI erros.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org