You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/02/19 03:10:54 UTC
[GitHub] Leemoonsoo commented on a change in pull request #3312:
[ZEPPELIN-4004] Fix RemoteResource.invokeMethod()
Leemoonsoo commented on a change in pull request #3312: [ZEPPELIN-4004] Fix RemoteResource.invokeMethod()
URL: https://github.com/apache/zeppelin/pull/3312#discussion_r257877678
##########
File path: zeppelin-zengine/src/test/java/org/apache/zeppelin/resource/DistributedResourcePoolTest.java
##########
@@ -44,8 +46,9 @@
public void setUp() throws Exception {
super.setUp();
InterpreterSetting interpreterSetting = interpreterSettingManager.getByName("mock_resource_pool");
+ interpreterSetting.getOption().setPerNote(ISOLATED);
intp1 = (RemoteInterpreter) interpreterSetting.getInterpreter("user1", "note1", "mock_resource_pool");
- intp2 = (RemoteInterpreter) interpreterSetting.getInterpreter("user2", "note1", "mock_resource_pool");
+ intp2 = (RemoteInterpreter) interpreterSetting.getInterpreter("user2", "note2", "mock_resource_pool");
Review comment:
While `intp1` and `intp2` were configured to the same Note `note1` with `SHARED` mode, the test was instantiating `intp1` and `intp2` in the same process and didn't test access to the remote object in the remote process.
Therefore, changed interpreter option to per note `ISOLATED` and configured `intp1` for `note1` and `intp2 for `note2`, make sure `intp1` and `intp2` runs in different process.
In this way, it can reproduce error described in ZEPPELIN-4004
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services