You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "gf2121 (via GitHub)" <gi...@apache.org> on 2023/06/01 08:21:10 UTC

[GitHub] [calcite] gf2121 commented on pull request #3228: [CALCITE-5730] Initial null values can be dropped by EnumerableLimitSort with offset

gf2121 commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1571584494

   > Minor request: could you make the non-bug-related tests a bit more varied: different offset/limit values (not always 1), use asc/desc on order by, use different columns (not always commission+salary)
   
   @rubenada Sorry, for some reason I could not see this comment on github. Just got that from your latest comment. I have added a new commit to fix it. will squash commits when ready to merge :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org