You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/08/16 15:32:40 UTC

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #181: Changes from release feedback

darkma773r commented on a change in pull request #181:
URL: https://github.com/apache/commons-geometry/pull/181#discussion_r689641657



##########
File path: src/main/resources/pmd/pmd-ruleset.xml
##########
@@ -41,12 +41,14 @@
     <exclude name="UseUnderscoresInNumericLiterals" />
     <exclude name="GenericsNaming" />
     <exclude name="ConfusingTernary" />
+    <exclude name="FieldDeclarationsShouldBeAtStartOfClass" />

Review comment:
       No. I disagree with this in some cases since I often find it helpful to have frequently used inner types (particularly public enums and interfaces) at the top of the class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org