[GitHub] holdenk commented on a change in pull request #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator
URL: https://github.com/apache/spark/pull/17084#discussion_r255638776
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/mllib/evaluation/binary/BinaryLabelCounter.scala
 ##########
 @@ -24,14 +24,22 @@ package org.apache.spark.mllib.evaluation.binary
  * @param numNegatives number of negative labels
  */
 private[evaluation] class BinaryLabelCounter(
-    var numPositives: Long = 0L,
-    var numNegatives: Long = 0L) extends Serializable {
+    var numPositives: Double = 0.0,
 
 Review comment:
   This is no longer the number of positive records necessarily, maybe update this variable name as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org