You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sanpwc (via GitHub)" <gi...@apache.org> on 2024/02/09 11:43:49 UTC
[PR] IGNITE-21503 Fix ItRebalanceDistributedTest#testRebalanceWithTheSameNodes [ignite-3]
sanpwc opened a new pull request, #3194:
URL: https://github.com/apache/ignite-3/pull/3194
https://issues.apache.org/jira/browse/IGNITE-21503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21503 Fix ItRebalanceDistributedTest#testRebalanceWithTheSameNodes [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #3194:
URL: https://github.com/apache/ignite-3/pull/3194#discussion_r1484276744
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -766,11 +765,10 @@ private void directUpdateMetastoreRebalanceAssignmentKeys() throws Exception {
private void verifyThatRaftNodesAndReplicasWereStartedOnlyOnce() throws Exception {
for (int i = 0; i < NODE_COUNT; i++) {
- verify(
- getNode(i).raftManager,
- times(1)).startRaftGroupNodeWithoutService(any(), any(), any(), any(), any(RaftGroupOptions.class)
- );
- verify(getNode(i).replicaManager, times(1)).startReplica(any(), any(), any(), any(), any());
+ verify(getNode(i).raftManager, timeout(AWAIT_TIMEOUT_MILLIS).times(1))
+ .startRaftGroupNodeWithoutService(any(), any(), any(), any(), any(RaftGroupOptions.class));
+ verify(getNode(i).replicaManager, timeout(10_000).times(1))
Review Comment:
Yep, you are right. That's an auto conflict resolution artifact by the way. Anyway, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21503 Fix ItRebalanceDistributedTest#testRebalanceWithTheSameNodes [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #3194:
URL: https://github.com/apache/ignite-3/pull/3194#discussion_r1484276744
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -766,11 +765,10 @@ private void directUpdateMetastoreRebalanceAssignmentKeys() throws Exception {
private void verifyThatRaftNodesAndReplicasWereStartedOnlyOnce() throws Exception {
for (int i = 0; i < NODE_COUNT; i++) {
- verify(
- getNode(i).raftManager,
- times(1)).startRaftGroupNodeWithoutService(any(), any(), any(), any(), any(RaftGroupOptions.class)
- );
- verify(getNode(i).replicaManager, times(1)).startReplica(any(), any(), any(), any(), any());
+ verify(getNode(i).raftManager, timeout(AWAIT_TIMEOUT_MILLIS).times(1))
+ .startRaftGroupNodeWithoutService(any(), any(), any(), any(), any(RaftGroupOptions.class));
+ verify(getNode(i).replicaManager, timeout(10_000).times(1))
Review Comment:
Yep, you are right. That's an auto conflict resolution artifact by the way. Anyway fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21503 Fix ItRebalanceDistributedTest#testRebalanceWithTheSameNodes [ignite-3]
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #3194:
URL: https://github.com/apache/ignite-3/pull/3194#discussion_r1484263544
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -766,11 +765,10 @@ private void directUpdateMetastoreRebalanceAssignmentKeys() throws Exception {
private void verifyThatRaftNodesAndReplicasWereStartedOnlyOnce() throws Exception {
for (int i = 0; i < NODE_COUNT; i++) {
- verify(
- getNode(i).raftManager,
- times(1)).startRaftGroupNodeWithoutService(any(), any(), any(), any(), any(RaftGroupOptions.class)
- );
- verify(getNode(i).replicaManager, times(1)).startReplica(any(), any(), any(), any(), any());
+ verify(getNode(i).raftManager, timeout(AWAIT_TIMEOUT_MILLIS).times(1))
+ .startRaftGroupNodeWithoutService(any(), any(), any(), any(), any(RaftGroupOptions.class));
+ verify(getNode(i).replicaManager, timeout(10_000).times(1))
Review Comment:
You can use `AWAIT_TIMEOUT_MILLIS` here as well instead of 10_000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21503 Fix ItRebalanceDistributedTest#testRebalanceWithTheSameNodes [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc merged PR #3194:
URL: https://github.com/apache/ignite-3/pull/3194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org