You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/11 02:18:30 UTC
[GitHub] [dolphinscheduler] sketchmind commented on pull request #10675: [Fix-10665] [S3] Fix s3 download method
sketchmind commented on PR #10675:
URL: https://github.com/apache/dolphinscheduler/pull/10675#issuecomment-1179891348
> LGTM, nit: the `overwrite` is not be used? it's better to implements this, if we set overwrite then delete the exist dstfile, if we don't set overwrite we don't delete the exist dstFile event it is a directly.
Param overwrite is always true in org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread#downloadResource and the existence of the file has been handled in advance in org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread#downloadCheck,I think the overriding related processing logic should be kept. @SbloodyS suggested to remove this part considering the situation of task rerun,I don't know if it will affect the rerun, so I removed this part of the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org