You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2026/08/16 03:53:23 UTC

[PR] [To dev/1.3] Handle invalid DataNode id in region operations [iotdb]

CRZbulabula opened a new pull request, #18477:
URL: https://github.com/apache/iotdb/pull/18477

   ## Description
   
   Semantic backport of #18075 to `dev/1.3`.
   
   ### Behavior
   
   - Resolve the target DataNode before processing reconstruct and extend region requests.
   - Return `RECONSTRUCT_REGION_ERROR` or `EXTEND_REGION_ERROR` with the target id when it is not a registered DataNode, including when a ConfigNode id is supplied.
   - Avoid region resolution and procedure submission for invalid targets.
   - Preserve the existing behavior for registered DataNodes.
   
   ### Tests
   
   - `ProcedureManagerRegionOperationTest`
   - `IoTDBRegionGroupExpandAndShrinkForIoTV1IT#rejectInvalidTargetDataNodeTest`
   - `IoTDBRegionReconstructForIoTV1IT#rejectInvalidTargetDataNodeTest`
   - `IoTDBRegionGroupExpandAndShrinkForIoTV1IT#singleRegionTest`
   - Checkstyle and Spotless
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added unit tests.
   - [x] added integration tests.
   - [x] been tested in a test IoTDB cluster.
   
   <hr>
   
   ##### Key changed/added classes
   
   - `ProcedureManager`
   - `ProcedureManagerRegionOperationTest`
   - `IoTDBRegionGroupExpandAndShrinkForIoTV1IT`
   - `IoTDBRegionReconstructForIoTV1IT`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [To dev/1.3] Handle invalid DataNode id in region operations [iotdb]

Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula closed pull request #18477: [To dev/1.3] Handle invalid DataNode id in region operations
URL: https://github.com/apache/iotdb/pull/18477


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [To dev/1.3] Handle invalid DataNode id in region operations [iotdb]

Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula commented on PR #18477:
URL: https://github.com/apache/iotdb/pull/18477#issuecomment-5305730342

   Superseded by #18478, whose head branch is hosted directly in apache/iotdb.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org