[jira] [Commented] (FLINK-8785) JobSubmitHandler does not handle JobSubmissionExceptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510844#comment-16510844 ] 

ASF GitHub Bot commented on FLINK-8785:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6158

    [FLINK-8785][rest] Handle JobSubmissionExceptions

    ## What is the purpose of the change
    
    Currently, if a  `JobSubmissionException` occurs the `JobSubmissionHandler` only returns `505 Internal server error.`, with no details about the original exception.
    This PR modifies the handler to returns the messages of all exceptions in the stack trace.
    
    ## Brief change log
    
    * modify `RestHandlerException` to allow multiple error messages, similar to `ErrorResponseBody`
    * modify `JobSubmitHandler` to handle exceptions during the job submission
    
    ## Verifying this change
    
    * see `JobSubmitHandlerTest#testFailedJobSubmission
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8785

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6158
    
----
commit bdb9a7b3949ce0fc1d31e57459e51f593ee0b699
Author: zentol <ch...@...>
Date:   2018-06-13T09:15:35Z

    [FLINK-8785][rest] Handle JobSubmissionExceptions

----


> JobSubmitHandler does not handle JobSubmissionExceptions
> --------------------------------------------------------
>
>                 Key: FLINK-8785
>                 URL: https://issues.apache.org/jira/browse/FLINK-8785
>             Project: Flink
>          Issue Type: Bug
>          Components: Job-Submission, JobManager, REST
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>              Labels: flip-6
>
> If the job submission, i.e. {{DispatcherGateway#submitJob}} fails with a {{JobSubmissionException}} the {{JobSubmissionHandler}} returns "Internal server error" instead of signaling the failed job submission.
> This can for example occur if the transmitted execution graph is faulty, as tested by the \{{JobSubmissionFailsITCase}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)