[GitHub] [parquet-format] emkornfield commented on a diff in pull request #194: PARQUET-2257: Add bloom_filter_length to ColumnMetaData

["emkornfield (via GitHub)" <gi...@apache.org>]

emkornfield commented on code in PR #194:
URL: https://github.com/apache/parquet-format/pull/194#discussion_r1157961261


##########
src/main/thrift/parquet.thrift:
##########
@@ -753,6 +753,9 @@ struct ColumnMetaData {
 
   /** Byte offset from beginning of file to Bloom filter data. **/
   14: optional i64 bloom_filter_offset;
+
+  /** Size of Bloom filter data, in bytes. **/
+  15: optional i32 bloom_filter_length;

Review Comment:
   for future implementers we should add a comment noting that existing of one element does not indicate existence of the other (even though it is already implied by mapping).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org